Field425 has 102 methods (exceeds 20 allowed). Consider refactoring. Open
@SuppressWarnings("unused")
@Generated
public class Field425 extends Field implements Serializable {
/**
* Constant identifying the SRU to which this class belongs to.File Field425.java has 627 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* Copyright 2006-2023 Prowide
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.Method getValueDisplay has a Cognitive Complexity of 42 (exceeds 8 allowed). Consider refactoring. Open
@Override
public String getValueDisplay(int component, Locale locale) {
if (component < 1 || component > 40) {
throw new IllegalArgumentException("invalid component number " + component + " for field 425");
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getValueDisplay has 124 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String getValueDisplay(int component, Locale locale) {
if (component < 1 || component > 40) {
throw new IllegalArgumentException("invalid component number " + component + " for field 425");
}Method getComponentLabels has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public List<String> getComponentLabels() {
List<String> result = new ArrayList<>();
result.add(null);
result.add(null);Method parse has a Cognitive Complexity of 13 (exceeds 8 allowed). Consider refactoring. Open
@Override
public void parse(final String value) {
init(40);
/*
* This parser implementation needs review, the actual field format is not clear in the standard:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return getComponent(37);Avoid too many return statements within this method. Open
return getComponent(7);Avoid too many return statements within this method. Open
return getComponent(22);Avoid too many return statements within this method. Open
return getComponent(31);Avoid too many return statements within this method. Open
return getComponent(36);Avoid too many return statements within this method. Open
return getComponent(10);Avoid too many return statements within this method. Open
return getComponent(25);Avoid too many return statements within this method. Open
return getComponent(28);Avoid too many return statements within this method. Open
return getComponent(6);Avoid too many return statements within this method. Open
return getComponent(17);Avoid too many return statements within this method. Open
return getComponent(5);Avoid too many return statements within this method. Open
return getComponent(39);Avoid too many return statements within this method. Open
return getComponent(18);Avoid too many return statements within this method. Open
return getComponent(32);Avoid too many return statements within this method. Open
return getComponent(8);Avoid too many return statements within this method. Open
return getComponent(16);Avoid too many return statements within this method. Open
return getComponent(29);Avoid too many return statements within this method. Open
return getComponent(30);Avoid too many return statements within this method. Open
return getComponent(35);Avoid too many return statements within this method. Open
return getComponent(14);Avoid too many return statements within this method. Open
return getComponent(11);Avoid too many return statements within this method. Open
return getComponent(13);Avoid too many return statements within this method. Open
return getComponent(15);Avoid too many return statements within this method. Open
return getComponent(27);Avoid too many return statements within this method. Open
return getComponent(40);Avoid too many return statements within this method. Open
return getComponent(33);Avoid too many return statements within this method. Open
return getComponent(12);Avoid too many return statements within this method. Open
return getComponent(19);Avoid too many return statements within this method. Open
return getComponent(24);Avoid too many return statements within this method. Open
return getComponent(26);Avoid too many return statements within this method. Open
return getComponent(34);Avoid too many return statements within this method. Open
return getComponent(38);Avoid too many return statements within this method. Open
return null;Avoid too many return statements within this method. Open
return getComponent(20);Avoid too many return statements within this method. Open
return getComponent(9);Avoid too many return statements within this method. Open
return getComponent(21);Avoid too many return statements within this method. Open
return getComponent(23);Refactor this method to reduce its Cognitive Complexity from 42 to the 15 allowed. Open
public String getValueDisplay(int component, Locale locale) {- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.
See
Use already-defined constant 'COMPONENTS_PATTERN' instead of duplicating its value here. Open
return "SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS";- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
public void run() {
prepare("action1"); // Noncompliant - "action1" is duplicated 3 times
execute("action1");
release("action1");
}
@SuppressWarning("all") // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }
public String method3(String a) {
System.out.println("'" + a + "'"); // Compliant - literal "'" has less than 5 characters and is excluded
return ""; // Compliant - literal "" has less than 5 characters and is excluded
}
Compliant Solution
private static final String ACTION_1 = "action1"; // Compliant
public void run() {
prepare(ACTION_1); // Compliant
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Use already-defined constant 'PARSER_PATTERN' instead of duplicating its value here. Open
return "20*(S/S)";- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
public void run() {
prepare("action1"); // Noncompliant - "action1" is duplicated 3 times
execute("action1");
release("action1");
}
@SuppressWarning("all") // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }
public String method3(String a) {
System.out.println("'" + a + "'"); // Compliant - literal "'" has less than 5 characters and is excluded
return ""; // Compliant - literal "" has less than 5 characters and is excluded
}
Compliant Solution
private static final String ACTION_1 = "action1"; // Compliant
public void run() {
prepare(ACTION_1); // Compliant
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Similar blocks of code found in 2 locations. Consider refactoring. Open
@Override
public void parse(final String value) {
init(40);
/*
* This parser implementation needs review, the actual field format is not clear in the standard:- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 144.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76