Sign upLogin

prowide/prowide-core

View on GitHub
Star
src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java

Summary

Maintainability
F
4 days
Test Coverage

AbstractSwiftMessage has 102 methods (exceeds 20 allowed). Consider refactoring.
Open

@Entity
@Table(name = "swift_msg")
@Inheritance(strategy = InheritanceType.SINGLE_TABLE)
@DiscriminatorColumn(name = "type", length = 2)
public abstract class AbstractSwiftMessage implements Serializable, JsonSerializable {
Severity: Major
Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 1 day to fix

    File AbstractSwiftMessage.java has 705 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2006-2023 Prowide
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Major
    Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 1 day to fix

      Method equals has a Cognitive Complexity of 23 (exceeds 8 allowed). Consider refactoring.
      Open

          @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || !(o instanceof AbstractSwiftMessage)) return false;
        AbstractSwiftMessage that = (AbstractSwiftMessage) o;
      Severity: Minor
      Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method copyTo has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void copyTo(AbstractSwiftMessage msg) {
        msg.setMessage(getMessage());
        msg.setIdentifier(getIdentifier());
        msg.setSender(getSender());
        msg.setReceiver(getReceiver());
      Severity: Minor
      Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 1 hr to fix

        Method contains has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

            @SuppressWarnings("rawtypes")
    public boolean contains(Enum... statuses) {
        boolean result = false;
        List<SwiftMessageStatusInfo> l = getStatusTrail();
        if (l != null) {
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method contains has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

            public boolean contains(String... statuses) {
        boolean result = false;
        List<SwiftMessageStatusInfo> l = getStatusTrail();
        if (l != null) {
            for (SwiftMessageStatusInfo s : getStatusTrail()) {
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Define a constant instead of duplicating this literal "the strategy for metadata extraction cannot be null" 3 times.
        Open

                Objects.requireNonNull(metadataStrategy, "the strategy for metadata extraction cannot be null");
        Severity: Critical
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java by sonar-java

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

        Compliant Solution

        private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected AbstractSwiftMessage(
            final InputStream stream, final FileFormat fileFormat, final MessageMetadataStrategy metadataStrategy)
            throws IOException {
        Objects.requireNonNull(metadataStrategy, "the strategy for metadata extraction cannot be null");
        this.message = Lib.readStream(stream);
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java and 1 other location - About 40 mins to fix
        src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java on lines 197..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected AbstractSwiftMessage(
            final String content, final FileFormat fileFormat, final MessageMetadataStrategy metadataStrategy) {
        Objects.requireNonNull(metadataStrategy, "the strategy for metadata extraction cannot be null");
        this.message = StringUtils.trim(content);
        this.fileFormat = fileFormat;
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java and 1 other location - About 40 mins to fix
        src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java on lines 239..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            @OneToMany(orphanRemoval = true, cascade = CascadeType.ALL)
    @JoinColumn(name = "msg_id", nullable = false)
    @OrderColumn(name = "sort_key")
    private List<SwiftMessageNote> notes = new ArrayList<>();
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java and 1 other location - About 30 mins to fix
        src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java on lines 141..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            @OneToMany(orphanRemoval = true, cascade = CascadeType.ALL)
    @JoinColumn(name = "msg_id", nullable = false)
    @OrderColumn(name = "sort_key")
    private List<SwiftMessageRevision> revisions = new ArrayList<>();
        Severity: Minor
        Found in src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java and 1 other location - About 30 mins to fix
        src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java on lines 115..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status