Sign upLogin

prowide/prowide-core

View on GitHub
Star
src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java

Summary

Maintainability
C
7 hrs
Test Coverage

FieldTest has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

public class FieldTest {

    @Test
    public void testSetComponent() {
        final Field f = new Field70E();
Severity: Minor
Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java - About 3 hrs to fix

    Method testJoinComponents_01 has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Test
    public void testJoinComponents_01() {
        Field f = new Field70E();
        f.setComponent(1, "1");
        f.setComponent(2, "2");
    Severity: Minor
    Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java - About 1 hr to fix

      Method testSetComponent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Test
    public void testSetComponent() {
        final Field f = new Field70E();
        f.setComponent(2, "world");
        assertNull(f.getComponent(1));
      Severity: Minor
      Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java - About 1 hr to fix

        Define a constant instead of duplicating this literal "cruel" 4 times.
        Open

                f.setComponent(1, "cruel");
        Severity: Critical
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java by sonar-java

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

        Compliant Solution

        private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Define a constant instead of duplicating this literal ":INVE//JOE DOE" 4 times.
        Open

                Field95Q f = new Field95Q(":INVE//JOE DOE");
        Severity: Critical
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java by sonar-java

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

        Compliant Solution

        private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Define a constant instead of duplicating this literal "hello" 4 times.
        Open

                f.setComponent(2, "hello");
        Severity: Critical
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java by sonar-java

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

        Compliant Solution

        private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            @Test
    public void testLines_04() {
        Field50K f = new Field50K("ABC");
        assertEquals(1, f.getLines().size());
        assertNull(f.getLine(1));
        Severity: Major
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java and 3 other locations - About 35 mins to fix
        src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java on lines 265..271
        src/test/java/com/prowidesoftware/swift/model/field/GetLineTest.java on lines 308..314
        src/test/java/com/prowidesoftware/swift/model/field/GetLineTest.java on lines 316..322

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            @Test
    public void testLines_05() {
        Field50K f = new Field50K("ABC");
        assertEquals(1, f.getLines().size());
        assertNull(f.getLine(1));
        Severity: Major
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java and 3 other locations - About 35 mins to fix
        src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java on lines 257..263
        src/test/java/com/prowidesoftware/swift/model/field/GetLineTest.java on lines 308..314
        src/test/java/com/prowidesoftware/swift/model/field/GetLineTest.java on lines 316..322

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @Test
    public void testLines_03() {
        Field50K f = new Field50K("/12345");
        assertEquals(1, f.getLines().size());
        assertEquals("/12345", f.getLine(1));
        Severity: Minor
        Found in src/test/java/com/prowidesoftware/swift/model/field/FieldTest.java and 1 other location - About 35 mins to fix
        src/test/java/com/prowidesoftware/swift/model/field/GetLineTest.java on lines 300..306

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status