Sign upLogin

prowide/prowide-core

View on GitHub
Star
src/test/java/com/prowidesoftware/swift/model/field/NarrativeBuilderTest.java

Summary

Maintainability
A
1 hr
Test Coverage

Method testSupplement has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void testSupplement() {
        Narrative n = Narrative.builder(35)
                .addCodewordWithSupplement("10", "Primary text", "Additional Text")
                .addCodewordWithSupplement("11", "Primary text that should be wrapped in lines", "Additional Text")
Severity: Minor
Found in src/test/java/com/prowidesoftware/swift/model/field/NarrativeBuilderTest.java - About 1 hr to fix

    Define a constant instead of duplicating this literal "Additional Text" 5 times.
    Open

                    .addCodewordWithSupplement("10", "Primary text", "Additional Text")
    Severity: Critical
    Found in src/test/java/com/prowidesoftware/swift/model/field/NarrativeBuilderTest.java by sonar-java

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

    Compliant Solution

    private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "Primary text" 4 times.
    Open

                    .addCodewordWithSupplement("10", "Primary text", "Additional Text")
    Severity: Critical
    Found in src/test/java/com/prowidesoftware/swift/model/field/NarrativeBuilderTest.java by sonar-java

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

    Compliant Solution

    private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status