Sign upLogin

psono/psono-server

View on GitHub
Star
psono/restapi/models.py

Summary

Maintainability
D
2 days
Test Coverage

File models.py has 954 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django.db.models.signals import post_save, post_delete
from django.db import models
from django.dispatch import receiver
from django.core.cache import cache
from django.conf import settings
Severity: Major
Found in psono/restapi/models.py - About 2 days to fix

    Cyclomatic complexity is too high in method save. (14)
    Open

        def save(self, *args, **kwargs):

        try:
            stored_user = User.objects.get(pk=self.id)
    Severity: Minor
    Found in psono/restapi/models.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def save(self, *args, **kwargs):

        try:
            stored_user = User.objects.get(pk=self.id)
    Severity: Minor
    Found in psono/restapi/models.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

                if authkey_changed or public_key_changed  or secret_key_changed  or secret_key_nonce_changed  or private_key_changed  or private_key_nonce_changed:

                if hashing_parameters_changed or hashing_algorithm_changed:
                    Old_Credential.objects.filter(user_id=stored_user.id).delete()
    Severity: Major
    Found in psono/restapi/models.py - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status