Sign upLogin

pstuifzand/ekster

View on GitHub
Star
cmd/eksterd/hubbackend.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method hubIncomingBackend.run has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (h *hubIncomingBackend) run() error {
    ticker := time.NewTicker(10 * time.Minute)
    quit := make(chan struct{})

    go func() {
Severity: Minor
Found in cmd/eksterd/hubbackend.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hubIncomingBackend.Feeds has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (h *hubIncomingBackend) Feeds() ([]Feed, error) {
    conn := h.pool.Get()
    defer conn.Close()
    feeds := []Feed{}
Severity: Minor
Found in cmd/eksterd/hubbackend.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hubIncomingBackend.CreateFeed has 6 return statements (exceeds 4 allowed).
Open

func (h *hubIncomingBackend) CreateFeed(topic string, channel string) (int64, error) {
    conn := h.pool.Get()
    defer conn.Close()

    // TODO(peter): check if topic already is registered
Severity: Major
Found in cmd/eksterd/hubbackend.go - About 40 mins to fix

FIXME found
Open

    // FIXME(peter): replace with set of currently checked feeds
Severity: Minor
Found in cmd/eksterd/hubbackend.go by fixme

TODO found
Open

    // TODO(peter): check if topic already is registered
Severity: Minor
Found in cmd/eksterd/hubbackend.go by fixme

There are no issues that match your filters.

Category
Status