Sign upLogin

pstuifzand/ekster

View on GitHub
Star
pkg/client/requests.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Client.FollowGetList has 5 return statements (exceeds 4 allowed).
Open

func (c *Client) FollowGetList(channel string) ([]microsub.Feed, error) {
    args := make(map[string]string)
    args["channel"] = channel
    res, err := c.microsubGetRequest("follow", args)
    if err != nil {
Severity: Major
Found in pkg/client/requests.go - About 35 mins to fix

Method Client.TimelineGet has 5 return statements (exceeds 4 allowed).
Open

func (c *Client) TimelineGet(before, after, channel string) (microsub.Timeline, error) {
    args := make(map[string]string)
    args["after"] = after
    args["before"] = before
    args["channel"] = channel
Severity: Major
Found in pkg/client/requests.go - About 35 mins to fix

Method Client.PreviewURL has 5 return statements (exceeds 4 allowed).
Open

func (c *Client) PreviewURL(url string) (microsub.Timeline, error) {
    args := make(map[string]string)
    args["url"] = url
    res, err := c.microsubPostRequest("preview", args)
    if err != nil {
Severity: Major
Found in pkg/client/requests.go - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Client) FollowURL(channel, url string) (microsub.Feed, error) {
    args := make(map[string]string)
    args["channel"] = channel
    args["url"] = url
    res, err := c.microsubPostRequest("follow", args)
Severity: Major
Found in pkg/client/requests.go and 1 other location - About 2 hrs to fix
pkg/client/requests.go on lines 252..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 192.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Client) ChannelsUpdate(uid, name string) (microsub.Channel, error) {
    args := make(map[string]string)
    args["name"] = name
    args["channel"] = uid
    res, err := c.microsubPostRequest("channels", args)
Severity: Major
Found in pkg/client/requests.go and 1 other location - About 2 hrs to fix
pkg/client/requests.go on lines 284..300

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 192.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status