Sign upLogin

pstuifzand/ekster

View on GitHub
Star
pkg/timeline/redisset.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method redisSortedSetTimeline.Items has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (timeline *redisSortedSetTimeline) Items(before, after string) (microsub.Timeline, error) {
    conn := timeline.pool.Get()
    defer conn.Close()

    items := []microsub.Item{}
Severity: Minor
Found in pkg/timeline/redisset.go - About 1 hr to fix

Method redisSortedSetTimeline.AddItem has 7 return statements (exceeds 4 allowed).
Open

func (timeline *redisSortedSetTimeline) AddItem(item microsub.Item) (bool, error) {
    conn := timeline.pool.Get()
    defer conn.Close()

    channel := timeline.channel
Severity: Major
Found in pkg/timeline/redisset.go - About 45 mins to fix

FIXME found
Open

            // FIXME: what should we do if one of the items doen't unmarshal?
Severity: Minor
Found in pkg/timeline/redisset.go by fixme

There are no issues that match your filters.

Category
Status