Sign upLogin

pstuifzand/ekster

View on GitHub
Star
pkg/websub/subscribe.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function parseBodyLinks has 11 return statements (exceeds 4 allowed).
Open

func parseBodyLinks(client *http.Client, topic string) (string, error) {
    resp, err := client.Get(topic)

    if err != nil {
        return "", err
Severity: Major
Found in pkg/websub/subscribe.go - About 1 hr to fix

Function isFeedContentType has 5 return statements (exceeds 4 allowed).
Open

func isFeedContentType(contentType string) bool {
    if strings.HasPrefix(contentType, "application/rss+xml") {
        return true
    }
    if strings.HasPrefix(contentType, "application/atom+xml") {
Severity: Major
Found in pkg/websub/subscribe.go - About 35 mins to fix

Function parseBodyLinks has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
Open

func parseBodyLinks(client *http.Client, topic string) (string, error) {
    resp, err := client.Get(topic)

    if err != nil {
        return "", err
Severity: Minor
Found in pkg/websub/subscribe.go - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status