Sign upLogin

psychob/dependency-injection

View on GitHub
Star

Showing 16 of 16 total issues

Function fetchArgumentsFrom_TPD has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

        protected function fetchArgumentsFrom_TPD(ReflectionFunctionAbstract $ref, array $arguments,
                                                  RegistrationEntry $def, string $className = 'anonymous'): array
        {
            if ($def->isAutoWire() && empty($def->getArguments())) {
                return $this->fetchArgumentsFrom_TP($ref, $arguments, $className);
Severity: Minor
Found in src/Injector.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function inject has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        public function inject($func, array $arguments = [])
        {
            if (is_array($func)) {
                if (count($func) === 2) {
                    if ($func[1] === '__construct') {
Severity: Minor
Found in src/Injector.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchArgumentsFrom_TP has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        protected function fetchArgumentsFrom_TP(ReflectionFunctionAbstract $ref, array $parameters,
                                                 string $className = 'anonymous'): array
        {
            if (empty($parameters)) {
                return $this->fetchArgumentsFrom_T($ref, $className);
Severity: Minor
Found in src/Injector.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        public function get(string $class)
        {
            if (array_key_exists($class, $this->buildDefinitions)) {
                $obj = $this->injector->make($class);
Severity: Minor
Found in src/Container.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchArgumentsFrom_TD has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        protected function fetchArgumentsFrom_TD(ReflectionFunctionAbstract $ref, RegistrationEntry $def,
                                                 string $className = 'anonymous'): array
        {
            if ($def->isAutoWire() && empty($def->getArguments())) {
                return $this->fetchArgumentsFrom_T($ref, $className);
Severity: Minor
Found in src/Injector.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    } else {
                        [$value, $returned] = $this->resolveParameterWithDefinition($param, $def, $className,
                                                                                    $ref->getName());

                        if ($returned) {
Severity: Major
Found in src/Injector.php and 1 other location - About 1 hr to fix
src/Injector.php on lines 164..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                foreach ($ref->getParameters() as $no => $param) {
                    [$value, $returned] = $this->resolveParameterWithDefinition($param, $def, $className,
                                                                                $ref->getName());

                    if ($returned) {
Severity: Major
Found in src/Injector.php and 1 other location - About 1 hr to fix
src/Injector.php on lines 198..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method calculateMessage has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function calculateMessage(): string
        {
            $allElements = $this->pack(...$this->keysInterfaces, ...$this->keysInitialized, ...$this->keysDefinitions);
            $onlyClassName = [];
            $ranks = [];
Severity: Minor
Found in src/Exceptions/ClassNotFoundException.php - About 1 hr to fix

    Function autowirePath has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            public function autowirePath(string ...$paths): void
        {
            $finder = new Finder();
            $finder->ignoreDotFiles(true)->ignoreUnreadableDirs()->files()->in($paths)->name('*.php');
    Severity: Minor
    Found in src/Container.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public function __construct(string $name, bool $autoWire, array $arguments, bool $isSingleton, string $bindType,
                                    $bind)
    Severity: Minor
    Found in src/Registration/RegistrationEntry.php - About 45 mins to fix

      Function fetchArgumentsFrom has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              protected function fetchArgumentsFrom(ReflectionFunctionAbstract $method, array $arguments,
                                              ?RegistrationEntry $def, string $className = 'anonymous'): array
        {
            if ($def === NULL) {
                if (empty($arguments)) {
      Severity: Minor
      Found in src/Injector.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public function __construct(string $class, string $method, string $paramName, array $cycle,
                                    ?\Throwable $previous = NULL)
      Severity: Minor
      Found in src/Exceptions/CantInjectParameterException.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public function __construct(string $class, array $keysInitialized, array $keysDefinitions,
                                    array $keysInterfaces, ?Throwable $previous = NULL)
        Severity: Minor
        Found in src/Exceptions/ClassNotFoundException.php - About 35 mins to fix

          Function calculateMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                  private function calculateMessage(): string
        {
            $allElements = $this->pack(...$this->keysInterfaces, ...$this->keysInitialized, ...$this->keysDefinitions);
            $onlyClassName = [];
            $ranks = [];
          Severity: Minor
          Found in src/Exceptions/ClassNotFoundException.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                              return $this->inject($bind);
          Severity: Major
          Found in src/Injector.php - About 30 mins to fix

            Function makeNewInstance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    protected function makeNewInstance(string $class, array $arguments)
        {
            try {
                if (in_array($class, $this->injectingCycle)) {
                    throw new CyclicDependencyException($class, $this->injectingCycle);
            Severity: Minor
            Found in src/Injector.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language