Sign upLogin

ptomulik/puppet-portsng

View on GitHub
Star

Showing 55 of 55 total issues

Gem beaker requirements already given on line 55 of the Gemfile.
Open

    gem 'beaker', *location_for(ENV['BEAKER_VERSION'] || '~> 2')
Severity: Minor
Found in Gemfile by rubocop

A Gem's requirements should be listed only once in a Gemfile.

Example:

# bad
gem 'rubocop'
gem 'rubocop'

# bad
group :development do
  gem 'rubocop'
end

group :test do
  gem 'rubocop'
end

# good
group :development, :test do
  gem 'rubocop'
end

# good
gem 'rubocop', groups: [:development, :test]

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem puppetlabs_spec_helper should appear before rake.
Open

    gem 'puppetlabs_spec_helper', '< 2.0.0', :require => false
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem beaker should appear before beaker-rspec.
Open

    gem 'beaker', *location_for(ENV['BEAKER_VERSION'] || '>= 3.2.0')
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

%w-literals should be delimited by [ and ].
Open

    prepare_options(ops, self.class::DEFAULT_INSTALL_OPTIONS, %w(-N), %w(-R -f))
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%w-literals should be delimited by [ and ].
Open

    prepare_options(ops, self.class::DEFAULT_UPGRADE_OPTIONS, %w(), %w(-f -N))
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Gem nokogiri requirements already given on line 46 of the Gemfile.
Open

    gem 'nokogiri', '< 1.7', :require => false
Severity: Minor
Found in Gemfile by rubocop

A Gem's requirements should be listed only once in a Gemfile.

Example:

# bad
gem 'rubocop'
gem 'rubocop'

# bad
group :development do
  gem 'rubocop'
end

group :test do
  gem 'rubocop'
end

# good
group :development, :test do
  gem 'rubocop'
end

# good
gem 'rubocop', groups: [:development, :test]

%w-literals should be delimited by [ and ].
Open

      moddeps = %w(portsutil backports)
Severity: Minor
Found in spec/spec_helper_acceptance.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%w-literals should be delimited by [ and ].
Open

  self::DEFAULT_INSTALL_OPTIONS = %w(-N -M BATCH=yes).freeze
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem term-ansicolor should appear before tins.
Open

    gem 'term-ansicolor', '< 1.4.0'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Line is too long. [89/80]
Open

  versions = ['9.0', '9.1', '9.2', '9.3', '10.1', '10.2', '10.3', '11.0', '11.1', '12.0']
Severity: Minor
Found in Vagrantfile by rubocop

Empty line detected around arguments.
Open


  `package_settings` shall be a hash with port's option names as keys (all
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cops checks if empty lines exist around the arguments of a method invocation.

Example:

# bad
do_something(
  foo

)

process(bar,

        baz: qux,
        thud: fred)

some_method(

  [1,2,3],
  x: y
)

# good
do_something(
  foo
)

process(bar,
        baz: qux,
        thud: fred)

some_method(
  [1,2,3],
  x: y
)

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem beaker should appear before beaker-rspec.
Open

    gem 'beaker', *location_for(ENV['BEAKER_VERSION'] || '~> 1')
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Line is too long. [94/80]
Open

  gem 'rspec', '~> 2.0' if ver(RUBY_VERSION) >= ver('1.8.7') && ver(RUBY_VERSION) < ver('1.9')
Severity: Minor
Found in Gemfile by rubocop

Avoid multi-line ternary operators, use if or unless instead.
Open

    default_puppet = host['platform'] =~ /9\.[0-1]/ ? 'puppet' :
                     (host['platform'] =~ /10\.[0-4]/ ? 'puppet4' : 'puppet5')
Severity: Minor
Found in spec/spec_helper_acceptance.rb by rubocop

This cop checks for multi-line ternary op expressions.

Example:

# bad
a = cond ?
  b : c
a = cond ? b :
    c
a = cond ?
    b :
    c

# good
a = cond ? b : c
a =
  if cond
    b
  else
    c
  end

Gem rspec-puppet requirements already given on line 36 of the Gemfile.
Open

    gem 'rspec-puppet'
Severity: Minor
Found in Gemfile by rubocop

A Gem's requirements should be listed only once in a Gemfile.

Example:

# bad
gem 'rubocop'
gem 'rubocop'

# bad
group :development do
  gem 'rubocop'
end

group :test do
  gem 'rubocop'
end

# good
group :development, :test do
  gem 'rubocop'
end

# good
gem 'rubocop', groups: [:development, :test]

Empty line detected around arguments.
Open


      package { 'www/apache22':
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cops checks if empty lines exist around the arguments of a method invocation.

Example:

# bad
do_something(
  foo

)

process(bar,

        baz: qux,
        thud: fred)

some_method(

  [1,2,3],
  x: y
)

# good
do_something(
  foo
)

process(bar,
        baz: qux,
        thud: fred)

some_method(
  [1,2,3],
  x: y
)

Empty line detected around arguments.
Open


  `install_options` are passed to `portupgrade` command when installing,
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cops checks if empty lines exist around the arguments of a method invocation.

Example:

# bad
do_something(
  foo

)

process(bar,

        baz: qux,
        thud: fred)

some_method(

  [1,2,3],
  x: y
)

# good
do_something(
  foo
)

process(bar,
        baz: qux,
        thud: fred)

some_method(
  [1,2,3],
  x: y
)

%w-literals should be delimited by [ and ].
Open

    self::DEFAULT_UNINSTALL_OPTIONS = %w(delete -y).freeze
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Empty line detected around arguments.
Open


  `uninstall_options` are passed to uninstall command. When the target system
Severity: Minor
Found in lib/puppet/provider/package/portsng.rb by rubocop

This cops checks if empty lines exist around the arguments of a method invocation.

Example:

# bad
do_something(
  foo

)

process(bar,

        baz: qux,
        thud: fred)

some_method(

  [1,2,3],
  x: y
)

# good
do_something(
  foo
)

process(bar,
        baz: qux,
        thud: fred)

some_method(
  [1,2,3],
  x: y
)

Avoid single-line method definitions.
Open

def ver(s); Gem::Version.new(s.dup); end
Severity: Minor
Found in Gemfile by rubocop

This cop checks for single-line method definitions that contain a body. It will accept single-line methods with no body.

Example:

# bad
def some_method; body end
def link_to(url); {:name => url}; end
def @table.columns; super; end

# good
def no_op; end
def self.resource_class=(klass); end
def @table.columns; end
Severity
Category
Status
Source
Language