ptondereau/Laravel-UPS-Api

View on GitHub

Showing 8 of 8 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerShipping(): void
    {
        $this->app->singleton('ups.shipping', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerQuantumView(): void
    {
        $this->app->singleton('ups.quantum-view', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerTimeInTransit(): void
    {
        $this->app->singleton('ups.time-in-transit', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerLocator(): void
    {
        $this->app->singleton('ups.locator', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerTradeability(): void
    {
        $this->app->singleton('ups.tradeability', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerTracking(): void
    {
        $this->app->singleton('ups.tracking', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerAddressValidation(): void
    {
        $this->app->singleton('ups.address-validation', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 73..87
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    protected function registerSimpleAddressValidation(): void
    {
        $this->app->singleton('ups.simple-address-validation', function (Container $app) {
            $config = $app->config->get('ups');

Severity: Major
Found in src/UpsApiServiceProvider.php and 7 other locations - About 40 mins to fix
src/UpsApiServiceProvider.php on lines 57..71
src/UpsApiServiceProvider.php on lines 89..103
src/UpsApiServiceProvider.php on lines 105..119
src/UpsApiServiceProvider.php on lines 136..150
src/UpsApiServiceProvider.php on lines 152..166
src/UpsApiServiceProvider.php on lines 168..182
src/UpsApiServiceProvider.php on lines 184..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language