Sign upLogin

publiclab/image-sequencer

View on GitHub
Star

Showing 206 of 267 total issues

Function otsu has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function otsu(histData) {
  let total = 0;
  for (let t = 0; t < 256; t++) total += histData[t];

  let sum = 0;
Severity: Minor
Found in src/modules/Threshold/Threshold.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CropModule has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function CropModule(options, UI) {

  // we should get UI to return the image thumbnail so we can attach our own UI extensions
  // add our custom in-module html ui:
  if (options.step.inBrowser && !options.noUI) var ui = require('./Ui.js')(options.step, UI);
Severity: Minor
Found in src/modules/Crop/Module.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Crop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function Crop(pixels, options, cb) {
  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  options.x = options.x || defaults.x;
  options.y = options.y || defaults.y;
Severity: Minor
Found in src/modules/Crop/Crop.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Dynamic has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function Dynamic(options, UI) {
  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  var output;

  // This function is called on every draw.
Severity: Minor
Found in src/modules/Dynamic/Module.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doubleThreshold has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

function doubleThreshold(pixels, highThresholdRatio, lowThresholdRatio, grads, strongEdgePixels, weakEdgePixels, pixelsToBeSupressed) {
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 50 mins to fix

Function exports has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

module.exports = function Rotate(pixels, finalPixels, rotate_value, width, height, cos, sin){
Severity: Major
Found in src/modules/Rotate/Rotate.js - About 50 mins to fix

Avoid deeply nested control flow statements.
Open

        for (let i = 0; i < iMax && i < w; i++) {
          for (let j = 0; j < jMax && j < h; j++) {
            let x = i, y = j + Math.abs(options.Y_value);
            pixelSetter(x, y, [pixels.get(i, j, 0), pixels.get(i, j, 1), pixels.get(i, j, 2), pixels.get(i, j, 3)], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      for(var s in args[0]) {
        json_q.push({
          name: args[0][s],
          o: args[1]
        });
Severity: Major
Found in src/FormatInput.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if (index < 0) index += size + 1;
Severity: Major
Found in src/FormatInput.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (pixels.data[curr + channels - 1] === 0) {
              const prev = prevIndex + j * channels;
  
              for (let k = 0; k < channels; ++k) {
                pixels.data[curr + k] = pixels.data[prev + k];
Severity: Major
Found in src/modules/_nomodule/PixelManipulation.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x + 1][y]) && (grads[x][y] >= grads[x - 1][y]))) {
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x + 1][y + 1]) && (grads[x][y] >= grads[x - 1][y - 1]))){
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (k >= w && l >= h && ((k - w) >= (l - h))) {
              continue;
            }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function changePixel has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

          function changePixel(r2, g2, b2, a2, x, y) {
Severity: Minor
Found in src/modules/Mask/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (var l = 0; l < (h + options.Y_value); l++) {
            if (l + (k * (options.Y_value / Math.abs(options.X_value))) - (options.Y_value + h) > 0 && l >= h) {
              continue;
            }
            let val = 255 - ((k / Math.abs(options.X_value)) * 255);
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (inputDesc.type.toLowerCase() == 'range') {
              html +=
                '"min="' +
                inputDesc.min +
                '"max="' +
Severity: Major
Found in examples/lib/defaultHtmlStepUi.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (var l = h; l < (h + options.Y_value); l++) {
            let val = ((l - h) / options.Y_value * 255);
            pixelSetter(k, l, [val, val, val, 255], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

        for (var k = w; k < (w + options.X_value); k++) {
          for (var l = 0; l < (h + Math.abs(options.Y_value)); l++) {
            let val = (((k - w) / options.X_value) * 255);
            pixelSetter(k, l, [val, val, val, 255], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function changePixel has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      function changePixel(r1, g1, b1, a1, x, y) {
Severity: Minor
Found in src/modules/Overlay/Module.js - About 45 mins to fix

Function DoNothing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function DoNothing(options, UI) {

  var output;

  var gl = require('fisheyegl');
Severity: Minor
Found in src/modules/FisheyeGl/Module.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language