Sign upLogin

publiclab/mapknitter

View on GitHub
Star
app/controllers/maps_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class MapsController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class MapsController < ApplicationController
  protect_from_forgery except: :export

  before_action :require_login, only: %i(update destroy)
  before_action :require_login_or_anon, only: %i(edit)
Severity: Minor
Found in app/controllers/maps_controller.rb - About 2 hrs to fix

    Method archive has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def archive
    if logged_in? && current_user.can_delete?(@map)
      @map.archived = true
      @map.status = Map::Status::BANNED
      if @map.save
    Severity: Minor
    Found in app/controllers/maps_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    if logged_in?
      @map = current_user.maps.new(map_params)
      @map.author = current_user.login # eventually deprecate
    else
    Severity: Minor
    Found in app/controllers/maps_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status