Sign upLogin

publiclab/mapknitter

View on GitHub
Star
app/models/map.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Map has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

class Map < ApplicationRecord
  include ActiveModel::Validations
  extend FriendlyId
  friendly_id :name, use: %i(slugged static)
Severity: Minor
Found in app/models/map.rb - About 4 hrs to fix

    File map.rb has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Map < ApplicationRecord
  include ActiveModel::Validations
  extend FriendlyId
  friendly_id :name, use: %i(slugged static)
    Severity: Minor
    Found in app/models/map.rb - About 2 hrs to fix

      Method average_cm_per_pixel has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def average_cm_per_pixel
    if !warpables.empty?
      scales = []
      count = 0
      average = 0
      Severity: Minor
      Found in app/models/map.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method best_cm_per_pixel has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def best_cm_per_pixel
    hist = images_histogram
    scores = []
    (0..(hist.length - 1)).each do |i|
      scores[i] = 0
      Severity: Minor
      Found in app/models/map.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method bbox has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.bbox(minlat, minlon, maxlat, maxlon, tag = nil)
      Severity: Minor
      Found in app/models/map.rb - About 35 mins to fix

        Method grouped_images_histogram has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def grouped_images_histogram(binsize)
    hist = []
    warpables.each do |warpable|
      res = warpable.cm_per_pixel
      next if res.nil?
        Severity: Minor
        Found in app/models/map.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status