app/models/drupal_file.rb
Method path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def path(size = :default)
if is_image?
if size == :thumb
"/#{filepath.gsub('sites/default/files/', 'sites/default/files/imagecache/thumb/')}"
elsif size == :default- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Redundant return detected. Open
Open
return filename- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks for redundant return expressions.
Example:
def test
return something
end
def test
one
two
three
return something
endIt should be extended to handle methods whose body is if/else or a case expression with a default branch.