Sign upLogin

publiclab/spectral-workbench

View on GitHub
Star
app/controllers/match_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method search has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def search
    id = params[:id]
    range = params[:fit]
    range ||= 100
Severity: Minor
Found in app/controllers/match_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def search
    id = params[:id]
    range = params[:fit]
    range ||= 100
Severity: Minor
Found in app/controllers/match_controller.rb - About 1 hr to fix

    Method livesearch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def livesearch
    data = ActiveSupport::JSON.decode('{' + params[:data] + '}')
    bins = (10...640).step(10)
    types = %w(a r g b)
    range = 50
    Severity: Minor
    Found in app/controllers/match_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method livesearch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def livesearch
    data = ActiveSupport::JSON.decode('{' + params[:data] + '}')
    bins = (10...640).step(10)
    types = %w(a r g b)
    range = 50
    Severity: Minor
    Found in app/controllers/match_controller.rb - About 1 hr to fix

      Method index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def index
    id = params[:id]

    if id.nil? # No need to search anything
      flash[:error] = 'ID is required for matching'
      Severity: Minor
      Found in app/controllers/match_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status