pug-php/js-phpize

View on GitHub
src/JsPhpize/Lexer/Pattern.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

The method __construct has a boolean flag argument $notInsideAWord, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($priority, $type, $patterns, $notInsideAWord = false)
Severity: Minor
Found in src/JsPhpize/Lexer/Pattern.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Yield statement has a value with type false but lexWith() is declared to yield values of type \JsPhpize\Lexer\Token in \Generator<\JsPhpize\Lexer\Token>
Open

        yield $lexer->scan($this->regex, $this->type);
Severity: Minor
Found in src/JsPhpize/Lexer/Pattern.php by phan

There are no issues that match your filters.

Category
Status