src/JsPhpize/Lexer/Pattern.php
The method __construct has a boolean flag argument $notInsideAWord, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($priority, $type, $patterns, $notInsideAWord = false)
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Yield statement has a value with type false
but lexWith()
is declared to yield values of type \JsPhpize\Lexer\Token
in \Generator<\JsPhpize\Lexer\Token>
Open
Open
yield $lexer->scan($this->regex, $this->type);
- Exclude checks