Sign upLogin

pug-php/js-phpize

View on GitHub
Star
src/JsPhpize/Nodes/Constant.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

The method __construct has a boolean flag argument $dotChild, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($type, $value, $dotChild = false)
Severity: Minor
Found in src/JsPhpize/Nodes/Constant.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Cannot modify read-only magic property \JsPhpize\Nodes\Constant->dotChild defined at /code/src/JsPhpize/Nodes/Constant.php:12
Open

        $this->dotChild = $dotChild;
Severity: Minor
Found in src/JsPhpize/Nodes/Constant.php by phan

Cannot modify read-only magic property \JsPhpize\Nodes\Constant->type defined at /code/src/JsPhpize/Nodes/Constant.php:11
Open

        $this->type = $type;
Severity: Minor
Found in src/JsPhpize/Nodes/Constant.php by phan

Cannot modify read-only magic property \JsPhpize\Nodes\Constant->value defined at /code/src/JsPhpize/Nodes/Constant.php:10
Open

        $this->value = $value;
Severity: Minor
Found in src/JsPhpize/Nodes/Constant.php by phan

There are no issues that match your filters.

Category
Status