Sign upLogin

pug-php/js-phpize

View on GitHub
Star
src/JsPhpize/Parser/Parser.php

Summary

Maintainability
D
2 days
Test Coverage
A
100%

File Parser.php has 393 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace JsPhpize\Parser;

use JsPhpize\JsPhpize;
Severity: Minor
Found in src/JsPhpize/Parser/Parser.php - About 5 hrs to fix

    Function parseParentheses has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parseParentheses($allowedSeparators = [',', ';'])
    {
        $parentheses = new Parenthesis();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
    Severity: Minor
    Found in src/JsPhpize/Parser/Parser.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class Parser has an overall complexity of 107 which is very high. The configured complexity threshold is 50.
    Open

    class Parser extends TokenExtractor
{
    /**
     * @var JsPhpize
     */
    Severity: Minor
    Found in src/JsPhpize/Parser/Parser.php by phpmd

    Function parseVariable has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parseVariable($name)
    {
        $children = [];
        $variable = null;
    Severity: Minor
    Found in src/JsPhpize/Parser/Parser.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseParentheses has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parseParentheses($allowedSeparators = [',', ';'])
    {
        $parentheses = new Parenthesis();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
    Severity: Minor
    Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

      Function parseHooksArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseHooksArray()
    {
        $array = new HooksArray();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
      Severity: Minor
      Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseBracketsArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseBracketsArray()
    {
        $array = new BracketsArray();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
      Severity: Minor
      Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parseKeywordStatement has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function parseKeywordStatement($token)
    {
        $name = $token->value;
        $keyword = new Block($name);
      Severity: Minor
      Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

        Method parseVariable has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function parseVariable($name)
    {
        $children = [];
        $variable = null;
        Severity: Minor
        Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

          Function parseInstruction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseInstruction($block, $token, &$initNext)
    {
        if ($token->type === 'keyword') {
            if ($token->isIn('var', 'const')) {
                $initNext = true;
          Severity: Minor
          Found in src/JsPhpize/Parser/Parser.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseFunctionCallChildren has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseFunctionCallChildren($function, $applicant = null)
    {
        $arguments = $this->parseParentheses()->nodes;
        $children = [];
          Severity: Minor
          Found in src/JsPhpize/Parser/Parser.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseInstructions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseInstructions($block)
    {
        $initNext = false;

        while ($token = $this->next()) {
          Severity: Minor
          Found in src/JsPhpize/Parser/Parser.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseKeywordStatement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseKeywordStatement($token)
    {
        $name = $token->value;
        $keyword = new Block($name);
          Severity: Minor
          Found in src/JsPhpize/Parser/Parser.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/JsPhpize/Parser/Parser.php - About 30 mins to fix

            Function parseBlock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function parseBlock($block)
    {
        $this->stack[] = $block;

        if (!$block->multipleInstructions) {
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            The method parseParentheses() has an NPath complexity of 482. The configured NPath complexity threshold is 200.
            Open

                protected function parseParentheses($allowedSeparators = [',', ';'])
    {
        $parentheses = new Parenthesis();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
    function bar() {
        // lots of complicated code
    }
}

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The method parseKeywordStatement() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
            Open

                protected function parseKeywordStatement($token)
    {
        $name = $token->value;
        $keyword = new Block($name);
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method parseParentheses() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
            Open

                protected function parseParentheses($allowedSeparators = [',', ';'])
    {
        $parentheses = new Parenthesis();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            Avoid assigning values to variables in if clauses and the like (line '326', column '46').
            Open

                protected function parseJsonMethod($method)
    {
        if ($method->type === 'variable' && ($function = $this->jsonMethodToPhpFunction($method->value))) {
            $this->skip(2);
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '211', column '17').
            Open

                protected function parseFunctionCallChildren($function, $applicant = null)
    {
        $arguments = $this->parseParentheses()->nodes;
        $children = [];
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '247', column '17').
            Open

                protected function parseVariable($name)
    {
        $children = [];
        $variable = null;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '157', column '17').
            Open

                protected function parseHooksArray()
    {
        $array = new HooksArray();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '469', column '13').
            Open

                protected function parseInstruction($block, $token, &$initNext)
    {
        if ($token->type === 'keyword') {
            if ($token->isIn('var', 'const')) {
                $initNext = true;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '346', column '14').
            Open

                protected function parseValue($token)
    {
        if (
            $token->type === 'constant' &&
            $token->value === 'JSON' &&
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '108', column '17').
            Open

                protected function parseParentheses($allowedSeparators = [',', ';'])
    {
        $parentheses = new Parenthesis();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '329', column '18').
            Open

                protected function parseJsonMethod($method)
    {
        if ($method->type === 'variable' && ($function = $this->jsonMethodToPhpFunction($method->value))) {
            $this->skip(2);
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '348', column '14').
            Open

                protected function parseValue($token)
    {
        if (
            $token->type === 'constant' &&
            $token->value === 'JSON' &&
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            Avoid assigning values to variables in if clauses and the like (line '191', column '17').
            Open

                protected function parseBracketsArray()
    {
        $array = new BracketsArray();
        $exceptionInfos = $this->exceptionInfos();
        $expectComma = false;
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpmd

            IfStatementAssignment

            Since: 2.7.0

            Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

            Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

            TODO found
            Open

                            // @TODO handle let scope here
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by fixme

            Line exceeds 120 characters; contains 127 characters
            Open

                        throw new Exception("':' expected but " . ($next->value ?: $next->type) . ' given ' . $this->exceptionInfos(), 15);
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpcodesniffer

            Expected 0 spaces after opening bracket; newline found
            Open

                    if (
            Severity: Minor
            Found in src/JsPhpize/Parser/Parser.php by phpcodesniffer

            There are no issues that match your filters.

            Category
            Status