Sign upLogin

pug-php/js-phpize

View on GitHub
Star
src/JsPhpize/Parser/TokenExtractor.php

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Function appendFunctionsCalls has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    protected function appendFunctionsCalls(&$value, $previousToken = null, $applicant = null)
    {
        while ($token = $this->get(0)) {
            if ($token->is('{') || $token->expectNoLeftMember()) {
                throw $this->unexpected($this->next());
Severity: Minor
Found in src/JsPhpize/Parser/TokenExtractor.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class TokenExtractor has an overall complexity of 55 which is very high. The configured complexity threshold is 50.
Open

abstract class TokenExtractor extends TokenCrawler
{
    protected function getBracketsArrayItemKeyFromToken($token)
    {
        $typeAndValue = new BracketsArrayItemKey($token);
Severity: Minor
Found in src/JsPhpize/Parser/TokenExtractor.php by phpmd

Method appendFunctionsCalls has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function appendFunctionsCalls(&$value, $previousToken = null, $applicant = null)
    {
        while ($token = $this->get(0)) {
            if ($token->is('{') || $token->expectNoLeftMember()) {
                throw $this->unexpected($this->next());
Severity: Minor
Found in src/JsPhpize/Parser/TokenExtractor.php - About 1 hr to fix

    Function getVariableChildFromToken has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getVariableChildFromToken(Token $token)
    {
        if ($token->is('.')) {
            $this->skip();
            $token = $this->next();
    Severity: Minor
    Found in src/JsPhpize/Parser/TokenExtractor.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getInitialValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getInitialValue($token)
    {
        if ($token->isFunction()) {
            return $this->parseFunction();
        }
    Severity: Minor
    Found in src/JsPhpize/Parser/TokenExtractor.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this->handleLeftOperator($this->expectValue($this->next(), $token), $token);
    Severity: Major
    Found in src/JsPhpize/Parser/TokenExtractor.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->parseKeyword($token);
      Severity: Major
      Found in src/JsPhpize/Parser/TokenExtractor.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->parseValue($token);
        Severity: Major
        Found in src/JsPhpize/Parser/TokenExtractor.php - About 30 mins to fix

          The method appendFunctionsCalls() has an NPath complexity of 301. The configured NPath complexity threshold is 200.
          Open

              protected function appendFunctionsCalls(&$value, $previousToken = null, $applicant = null)
    {
        while ($token = $this->get(0)) {
            if ($token->is('{') || $token->expectNoLeftMember()) {
                throw $this->unexpected($this->next());
          Severity: Minor
          Found in src/JsPhpize/Parser/TokenExtractor.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
    function bar() {
        // lots of complicated code
    }
}

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method appendFunctionsCalls() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

              protected function appendFunctionsCalls(&$value, $previousToken = null, $applicant = null)
    {
        while ($token = $this->get(0)) {
            if ($token->is('{') || $token->expectNoLeftMember()) {
                throw $this->unexpected($this->next());
          Severity: Minor
          Found in src/JsPhpize/Parser/TokenExtractor.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid assigning values to variables in if clauses and the like (line '75', column '13').
          Open

              protected function getInstructionFromToken($token)
    {
        if ($token->type === 'keyword') {
            return $this->parseKeyword($token);
        }
          Severity: Minor
          Found in src/JsPhpize/Parser/TokenExtractor.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseBracketsArray
          Open

                      return $this->parseBracketsArray();
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseTernary
          Open

                          $value = $this->parseTernary($value);
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseFunction
          Open

                      return $this->parseFunction();
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseParentheses
          Open

                      return $this->parseParentheses();
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseValue
          Open

                      return $this->parseValue($token);
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseParentheses
          Open

                      $keyword->setValue($this->parseParentheses($keyword->type === 'for' ? [';', 'in'] : [',', ';']));
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Argument 2 (leftHand) is \JsPhpize\Nodes\Dyiade|\JsPhpize\Nodes\DynamicValue|\JsPhpize\Nodes\FunctionCall|\JsPhpize\Nodes\Node|\JsPhpize\Nodes\Value|\JsPhpize\Readable but \JsPhpize\Nodes\Assignation::__construct() takes \JsPhpize\Nodes\Assignable defined at /code/src/JsPhpize/Nodes/Assignation.php:40
          Open

                              $value = new Assignation($token->type, $value, $valueToAssign);
          Severity: Minor
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseKeyword
          Open

                      return $this->parseKeyword($token);
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseKeyword
          Open

                      return $this->parseKeyword($token);
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseFunctionCallChildren
          Open

                          $value = $this->parseFunctionCallChildren($value, $applicant);
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Call to undeclared method \JsPhpize\Parser\TokenExtractor::parseHooksArray
          Open

                      return $this->parseHooksArray();
          Severity: Critical
          Found in src/JsPhpize/Parser/TokenExtractor.php by phan

          Line exceeds 120 characters; contains 123 characters
          Open

                          $value = $nextValue instanceof Constant && in_array($nextValue->value, ['Array', 'Object', 'String'], true)
          Severity: Minor
          Found in src/JsPhpize/Parser/TokenExtractor.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status