Sign upLogin

pug-php/pug-minify

View on GitHub
Star

Showing 7 of 7 total issues

File Minify.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Pug\Keyword;

use InvalidArgumentException;
Severity: Minor
Found in src/Pug/Keyword/Minify.php - About 3 hrs to fix

    The class Minify has an overall complexity of 69 which is very high. The configured complexity threshold is 50.
    Open

    class Minify
{
    /**
     * @var bool
     */
    Severity: Minor
    Found in src/Pug/Keyword/Minify.php by phpmd

    Minify has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Minify
{
    /**
     * @var bool
     */
    Severity: Minor
    Found in src/Pug/Keyword/Minify.php - About 3 hrs to fix

      Function scrollBlock has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function scrollBlock($block)
    {
        if (isset($block->nodes) && is_array($block->nodes)) {
            $nodes = array();
            foreach ($block->nodes as $key => $node) {
      Severity: Minor
      Found in src/Pug/Keyword/Minify/BlockExtractor.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return $this->params->source;
      Severity: Major
      Found in src/Pug/Keyword/Minify/ScriptParser.php - About 30 mins to fix

        Line exceeds 120 characters; contains 121 characters
        Open

                $this->outputDirectory = $this->outputDirectory ?: $this->getOption('outputDirectory', $this->assetDirectory[0]);
        Severity: Minor
        Found in src/Pug/Keyword/Minify.php by phpcodesniffer

        Line exceeds 120 characters; contains 121 characters
        Open

                return $parameters[1] . $this->parsePugInJs(str_replace('``', '`', $parameters[2]), $parameters[1], 'className');
        Severity: Minor
        Found in src/Pug/Keyword/Minify.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language