Sign upLogin

pug-php/pug-slim

View on GitHub
Star

Showing 23 of 23 total issues

Call to method compile from undeclared class \Pug\Pug
Open

            $this->adapter->compile(''); // Init ->files
Severity: Critical
Found in src/PugRenderer.php by phan

Call to method hasOption from undeclared class \Pug\Pug
Open

            return method_exists($this->adapter, 'hasOption') && !$this->adapter->hasOption($name)
Severity: Critical
Found in src/PugRenderer.php by phan

Define a constant instead of duplicating this literal "templates.path" 4 times.
Open

            $templatePath = isset($options['templates.path']) ? $options['templates.path'] : null;
Severity: Critical
Found in src/PugRenderer.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Severity
Category
Status
Source
Language