pug-php/pug-symfony

View on GitHub
src/Pug/Symfony/Traits/Installer.php

Summary

Maintainability
A
1 hr
Test Coverage

Method installSymfonyBundle has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        IOInterface $io,
        string $dir,
        string $bundle,
        string $bundleClass,
        callable $proceedTask,
Severity: Minor
Found in src/Pug/Symfony/Traits/Installer.php - About 45 mins to fix

    Method proceedTask has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function proceedTask(&$flags, $io, $taskResult, $flag, $successMessage, $message)
    Severity: Minor
    Found in src/Pug/Symfony/Traits/Installer.php - About 45 mins to fix

      The method installInSymfony5 uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $flags |= InstallerInterface::KERNEL_OK;
              }
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      syntax error, unexpected ')', expecting variable (T_VARIABLE)
      Open

          ): void {
      Severity: Critical
      Found in src/Pug/Symfony/Traits/Installer.php by phan

      Avoid variables with short names like $io. Configured minimum length is 3.
      Open

              $io = $event->getIO();
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $io. Configured minimum length is 3.
      Open

              IOInterface $io,
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $io. Configured minimum length is 3.
      Open

          public static function proceedTask(&$flags, $io, $taskResult, $flag, $successMessage, $message)
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $io. Configured minimum length is 3.
      Open

          protected static function askConfirmation(IOInterface $io, string $message): bool
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $io. Configured minimum length is 3.
      Open

              $io = $event->getIO();
      Severity: Minor
      Found in src/Pug/Symfony/Traits/Installer.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Line exceeds 120 characters; contains 142 characters
      Open

              $addBundle = static::askConfirmation($io, 'Would you like us to add automatically the pug bundle in your config/bundles.php? [Y/N] ');

      There are no issues that match your filters.

      Category
      Status