Sign upLogin

pug-php/pug-symfony

View on GitHub
Star
src/Pug/Twig/Environment.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function compileSource has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function compileSource(Source $source): string
    {
        $path = $source->getPath();

        if ($this->pugSymfonyEngine->supports($path)) {
Severity: Minor
Found in src/Pug/Twig/Environment.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compileSource has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compileSource(Source $source): string
    {
        $path = $source->getPath();

        if ($this->pugSymfonyEngine->supports($path)) {
Severity: Minor
Found in src/Pug/Twig/Environment.php - About 1 hr to fix

    Method fromTwigEnvironment has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function fromTwigEnvironment(
        TwigEnvironment $baseTwig,
        PugSymfonyEngine $pugSymfonyEngine,
        ContainerInterface $container,
    ): static {
    Severity: Minor
    Found in src/Pug/Twig/Environment.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ($newLine > $templateLine) {
                                $templateLine = $newLine;
                                $debugInfo[$codeFirstLine + $index] = $newLine;
                            }
      Severity: Major
      Found in src/Pug/Twig/Environment.php - About 45 mins to fix

        The method compileSource() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
        Open

            public function compileSource(Source $source): string
    {
        $path = $source->getPath();

        if ($this->pugSymfonyEngine->supports($path)) {
        Severity: Minor
        Found in src/Pug/Twig/Environment.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        syntax error, unexpected 'PugSymfonyEngine' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
        Open

            protected PugSymfonyEngine $pugSymfonyEngine;
        Severity: Critical
        Found in src/Pug/Twig/Environment.php by phan

        Line exceeds 120 characters; contains 122 characters
        Open

                    'optimizations'    => static::getPrivateExtensionProperty($baseTwig, OptimizerExtension::class, 'optimizers'),
        Severity: Minor
        Found in src/Pug/Twig/Environment.php by phpcodesniffer

        Line exceeds 120 characters; contains 125 characters
        Open

                    'autoescape'       => static::getPrivateExtensionProperty($baseTwig, EscaperExtension::class, 'defaultStrategy'),
        Severity: Minor
        Found in src/Pug/Twig/Environment.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status