Sign upLogin

puma/puma

View on GitHub
Star
lib/puma/control_cli.rb

Summary

Maintainability
D
2 days
Test Coverage

Method send_request has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def send_request
      uri = URI.parse @control_url

      host = uri.host
Severity: Minor
Found in lib/puma/control_cli.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(argv, stdout=STDOUT, stderr=STDERR)
      @state = nil
      @quiet = false
      @pidfile = nil
      @pid = nil
Severity: Major
Found in lib/puma/control_cli.rb - About 3 hrs to fix

    Method initialize has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(argv, stdout=STDOUT, stderr=STDERR)
      @state = nil
      @quiet = false
      @pidfile = nil
      @pid = nil
    Severity: Minor
    Found in lib/puma/control_cli.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_signal has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_signal
      unless @pid
        raise 'Neither pid nor control url available'
      end
    Severity: Minor
    Found in lib/puma/control_cli.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_request has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def send_request
      uri = URI.parse @control_url

      host = uri.host
    Severity: Major
    Found in lib/puma/control_cli.rb - About 2 hrs to fix

      Method send_signal has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def send_signal
      unless @pid
        raise 'Neither pid nor control url available'
      end
      Severity: Minor
      Found in lib/puma/control_cli.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def run
      return start if @command == 'start'
      prepare_configuration

      if Puma.windows? || @control_url && !NO_REQ_COMMANDS.include?(@command)
        Severity: Minor
        Found in lib/puma/control_cli.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method start has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def start
      require_relative 'cli'

      run_args = []
        Severity: Minor
        Found in lib/puma/control_cli.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status