Sign upLogin

puma/puma

View on GitHub
Star
test/test_integration_single.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class TestIntegrationSingle has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class TestIntegrationSingle < TestIntegration
  parallelize_me! if ::Puma.mri?

  def workers ; 0 ; end
Severity: Minor
Found in test/test_integration_single.rb - About 2 hrs to fix

    Method test_closed_listener has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def test_closed_listener
    skip_unless_signal_exist? :TERM

    cli_server "test/rackup/close_listeners.ru", merge_err: true
    connection = fast_connect
    Severity: Minor
    Found in test/test_integration_single.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method test_closed_listener has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def test_closed_listener
    skip_unless_signal_exist? :TERM

    cli_server "test/rackup/close_listeners.ru", merge_err: true
    connection = fast_connect
    Severity: Minor
    Found in test/test_integration_single.rb - About 1 hr to fix

      Method test_pre_existing_unix_after_idle_timeout has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def test_pre_existing_unix_after_idle_timeout
    skip_unless :unix

    File.open(@bind_path, mode: 'wb') { |f| f.puts 'pre existing' }
      Severity: Minor
      Found in test/test_integration_single.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status