Sign upLogin

punchcard-cms/punchcard

View on GitHub
Star

Showing 125 of 125 total issues

Function all has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const all = (query, models, next) => {
  const organize = utils.organize(query);
  const mods = _.cloneDeep(models) || [];

  return database.transaction(trx => {
Severity: Minor
Found in lib/api/apis.js - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

  if (!files || !Array.isArray(files) || !data || typeof data !== 'object' || !values || typeof values !== 'object' || !attributes || typeof attributes !== 'object') {
    return data;
  }
Severity: Critical
Found in lib/content/utils.js - About 1 hr to fix

Function page has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const page = (base, organized, count) => {
  const baseURL = `/${base}?sort=${organized.sort.by}&sort_dir=${organized.sort.dir}&per_page=${organized.page.limit}`;
  const pages = {
    first: `${baseURL}&page=1`,
  };
Severity: Minor
Found in lib/api/utils.js - About 1 hr to fix

Function ofType has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ofType = (query, model, models) => {
  const organize = utils.organize(query);
  const mods = _.cloneDeep(models) || [];
  let attrs = [];
Severity: Minor
Found in lib/api/apis.js - About 1 hr to fix

Function url has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const url = (req, res, next) => {
  const request = req;
  const err = {
    message: '',
    safe: `/${config.content.base}`,
Severity: Minor
Found in lib/content/middleware/index.js - About 1 hr to fix

Function exports has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (app) => {
  return new Promise(res => {
    // temp file storage location
    const dest = config.storage.temp.dest || 'public/tmp/';
Severity: Minor
Found in lib/init/routes.js - About 1 hr to fix

Function format has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const format = (content, attrs, models, query, trx) => {
  const params = _.cloneDeep(query) || {};
  let atrs = attrs || [];
  const mods = _.cloneDeep(models) || [];
Severity: Minor
Found in lib/api/utils.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return database('users').where({
    id: req.params.id,
  }).then(rows => {
    // application not in database; send to 404
    if (rows.length < 1) {
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const model = (workflowModel) => {
  let workflowConfig;
  if (workflowModel) {
    workflowConfig = workflowModel;
  }
Severity: Major
Found in lib/workflows/model.js and 1 other location - About 1 hr to fix
lib/applications/model.js on lines 63..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return database('applications').where({
    id: req.params.id,
  }).then(rows => {
    // application not in database; send to 404
    if (rows.length < 1) {
Severity: Major
Found in lib/applications/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setup has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const setup = (req, res, next) => {
  const errors = _.get(req.session, 'form.users.save.errors', {});
  const values = _.get(req.session, 'form.users.save.content', {});
  const merged = req.app.get('users-create-model') || {};
  const cfg = _.cloneDeep(config.users);
Severity: Minor
Found in lib/users/routes.js - About 1 hr to fix

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return database('applications').where('id', '=', id).update(data).then(() => {
    res.redirect(`/${config.applications.base}/${id}`);

    return data['client-secret'];
  }).catch(e => {
Severity: Major
Found in lib/applications/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const save = options => {
  const ids = options.endpoints.map(end => {
    return end.id;
  }).filter(id => {
    if (typeof id === 'undefined') {
Severity: Minor
Found in lib/applications/send.js - About 1 hr to fix

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return types.only('users-create', values, [merged], config).then(only => {
    return types.form(only, errors, config).then(form => {
      res.render('users/add', {
        title: 'Add a New User',
        form,
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    return database('users').insert(data).returning('*').then(user => {
      _.unset(req.session, 'form.users.save');

      if (_.includes(referrer, '/create-admin')) {
        return req.login(user[0], e => {
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    return database('users').where('id', '=', id).del().then(() => {
      _.unset(req.session, 'form.users.edit');
      _.unset(req.session, 'form.users.save');

      res.redirect(`/${config.users.base}`);
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return types.only('applications', values, [merged], config).then(only => {
    return types.form(only, errors, config).then(form => {
      res.render('applications/add', {
        form,
        action: `/${config.applications.base}/${config.applications.actions.save}`,
Severity: Major
Found in lib/applications/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return database.select('*').from('users').then(rows => {
    // if any users in DB, we redirect to the top
    if (rows.length > 1) {
      return res.redirect('/');
    }
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  return database.select('*').from('users').then(rows => {
    // if any users in DB, we give them a shameful error
    if (rows.length > 1) {
      const err = {
        message: 'A user or users already exist in this CMS',
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 274..289
lib/users/routes.js on lines 292..322

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

      return database('users').where('id', '=', id).update(data).then(() => {
        _.unset(req.session, 'form.users.edit');
        _.unset(req.session, 'form.users.save');

        res.redirect(`/${config.users.base}`);
Severity: Major
Found in lib/users/routes.js and 9 other locations - About 1 hr to fix
lib/applications/routes.js on lines 54..72
lib/applications/routes.js on lines 118..188
lib/applications/routes.js on lines 217..229
lib/users/routes.js on lines 32..59
lib/users/routes.js on lines 101..120
lib/users/routes.js on lines 164..219
lib/users/routes.js on lines 241..256
lib/users/routes.js on lines 292..322
lib/users/routes.js on lines 344..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language