puphpet/puphpet

View on GitHub
src/PuphpetBundle/Resources/public/custom.js

Summary

Maintainability
D
2 days
Test Coverage

File custom.js has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var PUPHPET = {};

/**
 * Catches anchor tag (#foo) in URL bar and displays proper tab
 */
Severity: Minor
Found in src/PuphpetBundle/Resources/public/custom.js - About 6 hrs to fix

    Function uploadConfig has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    PUPHPET.uploadConfig = function() {
        var dropzone = document.documentElement;
        var tid;
    
        dropzone.addEventListener('dragover', handleDragOver, false);
    Severity: Major
    Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

      Function addBlock has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      PUPHPET.addBlock = function() {
          $(document).on('click', '[data-toggle="add-block"]', function(e){
              e.stopPropagation();
              e.preventDefault && e.preventDefault();
      
      
      Severity: Major
      Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

        Function selectizeTagsUserInput has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        PUPHPET.selectizeTagsUserInput = function($element) {
            var $selectTagsUserInput = $('.select-tags-user-input', $element).selectize({
                plugins: ['remove_button'],
                delimiter: ',',
                persist: false,
        Severity: Minor
        Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

          Function runSelectize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          PUPHPET.runSelectize = function($element) {
              // input or select elements; allows user to create their own tags
              var $selectTagsEditable = $('.tags, .select-tags-editable', $element).selectize({
                  plugins: ['remove_button'],
                  delimiter: ',',
          Severity: Minor
          Found in src/PuphpetBundle/Resources/public/custom.js - About 1 hr to fix

            Function parseResponse has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function parseResponse($liContainer, $nestedTabsContainer, $panelBodyContainer, $row) {
                    var $template = $('#nested-tabs-template').clone(true);
                    var $tabLink  = $template.find('[data-toggle="tab"]');
                    var rowId     = $row[0].getAttribute('id');
                    var uniqid    = $row[0].getAttribute('data-uniqid');
            Severity: Minor
            Found in src/PuphpetBundle/Resources/public/custom.js - About 1 hr to fix

              Function uploadConfig has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              PUPHPET.uploadConfig = function() {
                  var dropzone = document.documentElement;
                  var tid;
              
                  dropzone.addEventListener('dragover', handleDragOver, false);
              Severity: Minor
              Found in src/PuphpetBundle/Resources/public/custom.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function enforceGroupSingleChoice has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              PUPHPET.enforceGroupSingleChoice = function() {
                  $('input[data-enforce-group-single]').on('change', function () {
                      var $this = $(this);
              
                      var group = this.getAttribute('data-enforce-group-single');
              Severity: Minor
              Found in src/PuphpetBundle/Resources/public/custom.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              PUPHPET.enableFormElements = function($container) {
                  $container.removeClass('form-elements-disabled');
              
                  $container.each(function() {
                      $(this)
              Severity: Major
              Found in src/PuphpetBundle/Resources/public/custom.js and 1 other location - About 1 hr to fix
              src/PuphpetBundle/Resources/public/custom.js on lines 514..522

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              PUPHPET.disableFormElements = function($container) {
                  $container.addClass('form-elements-disabled');
              
                  $container.each(function() {
                      $(this)
              Severity: Major
              Found in src/PuphpetBundle/Resources/public/custom.js and 1 other location - About 1 hr to fix
              src/PuphpetBundle/Resources/public/custom.js on lines 527..535

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status