Sign upLogin

pupilfirst/pupilfirst

View on GitHub
Star
app/controllers/users/sessions_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage
D
60%

Method auth_callback has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def auth_callback
      begin
        crypt = EncryptorService.new

        data =
Severity: Major
Found in app/controllers/users/sessions_controller.rb - About 2 hrs to fix

    Method auth_callback has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def auth_callback
      begin
        crypt = EncryptorService.new

        data =
    Severity: Minor
    Found in app/controllers/users/sessions_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def create
      @form =
        if params[:password_sign_in]
          Users::Sessions::SignInWithPasswordForm.new(Reform::OpenForm.new)
        elsif params[:email_link]
    Severity: Minor
    Found in app/controllers/users/sessions_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def token
      user =
        Users::AuthenticationService.new(
          current_school,
          params[:token]
    Severity: Minor
    Found in app/controllers/users/sessions_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status