Sign upLogin

pupilfirst/pupilfirst

View on GitHub
Star
app/services/daily_digest_service.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
98%

Method add_updates_for_coach has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def add_updates_for_coach(user)
    coach = user.faculty

    return [] if coach.blank?
Severity: Minor
Found in app/services/daily_digest_service.rb - About 1 hr to fix

    Method execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def execute
    debug_value = {}
    cache_new_and_popular_topics
    cache_older_topics_with_recent_activity
    Severity: Minor
    Found in app/services/daily_digest_service.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method first_five_topics_from_cache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def first_five_topics_from_cache(update_type, community_ids)
    topics = []

    @topic_details_cache[update_type].each do |topic|
      next unless topic[:community_id].in?(community_ids)
    Severity: Minor
    Found in app/services/daily_digest_service.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status