Sign upLogin

pupilfirst/pupilfirst

View on GitHub
Star
app/services/targets/details_service.rb

Summary

Maintainability
C
7 hrs
Test Coverage
A
96%

File details_service.rb has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Targets
  class DetailsService
    include RoutesResolvable

    def initialize(target, student, public_preview:)
Severity: Minor
Found in app/services/targets/details_service.rb - About 3 hrs to fix

    Method comments_for_submissions has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def comments_for_submissions
      #TODO - clean up this code using the list of attributes
      reaction_attributes = [
        :id,
        :user_id,
    Severity: Minor
    Found in app/services/targets/details_service.rb - About 1 hr to fix

      Method details has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def details
      details = default_props
      if @student.present?
        details =
          details.update(
      Severity: Minor
      Found in app/services/targets/details_service.rb - About 1 hr to fix

        Method links_to_adjacent_targets has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def links_to_adjacent_targets
      links = {}

      sorted_target_ids =
        @target
        Severity: Minor
        Found in app/services/targets/details_service.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status