Sign upLogin

puppetlabs/facter

View on GitHub
Star
lib/facter.rb

Summary

Maintainability
B
4 hrs
Test Coverage
B
87%

File facter.rb has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'pathname'
require_relative 'util/api_debugger' if ENV['API_DEBUG']

require_relative 'facter/version'
require_relative 'facter/framework/core/file_loader'
Severity: Minor
Found in lib/facter.rb - About 3 hrs to fix

    Method parse_exception has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_exception(exception, error_message)
      if exception.is_a?(Exception)
        error_message << exception.message if error_message.empty?

        if Options[:trace] && !exception.backtrace.nil?
    Severity: Minor
    Found in lib/facter.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method puppet_facts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def puppet_facts
      require 'puppet'

      # don't allow puppet logger to be injected in Facter
      Options[:allow_external_loggers] = false
    Severity: Minor
    Found in lib/facter.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status