Method define_resolution has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def define_resolution(resolution_name, options = {}, &block)
resolution_type = options.delete(:type) || :simple
resolve = create_or_return_resolution(resolution_name, resolution_type)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sort_by_weight has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def sort_by_weight(resolutions)
# sort resolutions:
# - descending by weight
# - multiple facts have the same weight but different types, the :external fact take precedence
# - multiple facts with the same weight and type, the order is preserved.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_or_return_resolution has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_or_return_resolution(resolution_name, resolution_type)
resolve = resolution(resolution_name)
if resolve
if resolution_type != resolve.resolution_type- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find_first_real_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def find_first_real_value(resolutions)
resolutions.each do |resolve|
begin
value = resolve.value
rescue Facter::ResolveCustomFactError- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"