Sign upLogin

pylhc/PyLHC

View on GitHub
Star
pylhc/data_extract/lsa.py

Summary

Maintainability
A
0 mins
Test Coverage
F
23%

File lsa.py has 312 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""
PyLSA
-----

This module provides useful functions to conveniently wrap the functionality of ``pjlsa``.
Severity: Minor
Found in pylhc/data_extract/lsa.py - About 3 hrs to fix

    Function get_trim_history has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        def get_trim_history(
            self, beamprocess: str, knobs: list, 
            start_time: AccDatetime = None, end_time: AccDatetime = None, 
            accelerator: str = "lhc"           
    ) -> dict:
    Severity: Minor
    Found in pylhc/data_extract/lsa.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_trim_history has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        def get_trim_history(
    Severity: Minor
    Found in pylhc/data_extract/lsa.py - About 35 mins to fix

      Function find_active_beamprocess_at_time has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          def find_active_beamprocess_at_time(
      Severity: Minor
      Found in pylhc/data_extract/lsa.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status