Sign upLogin

pylhc/submitter

View on GitHub
Star
pylhc_submitter/sixdesk_tools/stages.py

Summary

Maintainability
A
0 mins
Test Coverage
C
74%

File stages.py has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""
Stages
------

In this module the stages are organized.
Severity: Minor
Found in pylhc_submitter/sixdesk_tools/stages.py - About 3 hrs to fix

    Function should_run_stage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Invalid

        def should_run_stage(self):
        """ Checks if the stage should be run. """
        if not self.stage_file.exists():
            if self == 0:
                return True
    Severity: Minor
    Found in pylhc_submitter/sixdesk_tools/stages.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run_all_stages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Invalid

        def run_all_stages(jobname, jobargs, env):
        """ Run all stages in order. """
        LOG.info(f"vv---------------- Job {jobname} -------------------vv")
        for stage_name, stage_class in STAGE_ORDER.items():
            stage = stage_class(jobname, jobargs, env)
    Severity: Minor
    Found in pylhc_submitter/sixdesk_tools/stages.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Wontfix

                return False
    Severity: Major
    Found in pylhc_submitter/sixdesk_tools/stages.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status