Sign upLogin

pylhc/submitter

View on GitHub
Star
pylhc_submitter/submitter/htc_utils.py

Summary

Maintainability
A
3 hrs
Test Coverage
C
79%

Function write_bash has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

def write_bash(
    job_df: DataFrame,
    output_dir: Path = None,
    executable: str = "madx",
    cmdline_arguments: dict = None,
Severity: Minor
Found in pylhc_submitter/submitter/htc_utils.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function write_bash has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def write_bash(
Severity: Minor
Found in pylhc_submitter/submitter/htc_utils.py - About 35 mins to fix

    Function map_kwargs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def map_kwargs(add_dict: Dict[str, Any]) -> Dict[str, Any]:
    """
    Maps the kwargs for the job-file. 
    Some arguments have pre-defined choices and defaults, the remaining ones are just passed on.
    Severity: Minor
    Found in pylhc_submitter/submitter/htc_utils.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status