Sign upLogin

pyrmont/taipo

View on GitHub
Star
lib/taipo/parser/validater.rb

Summary

Maintainability
F
4 days
Test Coverage

Method validate has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

      def self.validate(str)
        msg = "The argument to this method must be of type String."
        raise ::TypeError, msg unless str.is_a? String
        msg = "The string to be checked was empty."
        raise Taipo::SyntaxError, msg if str.empty?
Severity: Minor
Found in lib/taipo/parser/validater.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_constraints has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

      def self.validate_constraints(str, start: 0)
        status_array = [ :rpr, :hsh, :cln, :sls, :qut, :cma, :spc, :oth ]
        counter_array = [ [ :const ], { const: ":' or '#" } ]

        state = SyntaxState.new(status_array, counter_array)
Severity: Minor
Found in lib/taipo/parser/validater.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.validate(str)
        msg = "The argument to this method must be of type String."
        raise ::TypeError, msg unless str.is_a? String
        msg = "The string to be checked was empty."
        raise Taipo::SyntaxError, msg if str.empty?
Severity: Major
Found in lib/taipo/parser/validater.rb - About 3 hrs to fix

    Method validate_regex has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.validate_regex(str, start: 0)
        status_array = [ :bsl, :sls, :opt, :oth ]
        counter_array = [ [ :backslash ], { backslash: '/' } ]

        state = SyntaxState.new(status_array, counter_array)
    Severity: Minor
    Found in lib/taipo/parser/validater.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_string has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.validate_string(str, start: 0)
        status_array = [ :bsl, :qut, :oth ]
        counter_array = [ [ :backslash ], { backslash: '/' } ]

        state = SyntaxState.new(status_array, counter_array)
    Severity: Minor
    Found in lib/taipo/parser/validater.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_constraints has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.validate_constraints(str, start: 0)
        status_array = [ :rpr, :hsh, :cln, :sls, :qut, :cma, :spc, :oth ]
        counter_array = [ [ :const ], { const: ":' or '#" } ]

        state = SyntaxState.new(status_array, counter_array)
    Severity: Major
    Found in lib/taipo/parser/validater.rb - About 2 hrs to fix

      Method validate_regex has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.validate_regex(str, start: 0)
        status_array = [ :bsl, :sls, :opt, :oth ]
        counter_array = [ [ :backslash ], { backslash: '/' } ]

        state = SyntaxState.new(status_array, counter_array)
      Severity: Minor
      Found in lib/taipo/parser/validater.rb - About 1 hr to fix

        Method validate_string has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.validate_string(str, start: 0)
        status_array = [ :bsl, :qut, :oth ]
        counter_array = [ [ :backslash ], { backslash: '/' } ]

        state = SyntaxState.new(status_array, counter_array)
        Severity: Minor
        Found in lib/taipo/parser/validater.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    when '/' #sls
            conditions = [ state.allowed?(:sls), state.outside?(:const) ]
            raise Taipo::SyntaxError, msg unless conditions.all?
            i = Taipo::Parser::Validater.validate_regex(str, start: i+1)
            state.prohibit_all except: [ :rpr, :cma ]
          Severity: Minor
          Found in lib/taipo/parser/validater.rb and 1 other location - About 35 mins to fix
          lib/taipo/parser/validater.rb on lines 289..294

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    when '"' #qut
            conditions = [ state.allowed?(:qut), state.outside?(:const) ]
            raise Taipo::SyntaxError, msg unless conditions.all?
            i = Taipo::Parser::Validater.validate_string(str, start: i+1)
            state.prohibit_all except: [ :rpr, :cma ]
          Severity: Minor
          Found in lib/taipo/parser/validater.rb and 1 other location - About 35 mins to fix
          lib/taipo/parser/validater.rb on lines 284..289

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    when ' ' # spc
            conditions = [ state.allowed?(:spc) ]
            raise Taipo::SyntaxError, msg unless conditions.all?
            state.prohibit_all except: [ :hsh, :cln, :sls, :qut, :oth ]
          else # oth
          Severity: Minor
          Found in lib/taipo/parser/validater.rb and 1 other location - About 15 mins to fix
          lib/taipo/parser/validater.rb on lines 162..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    when '|' # bar
            conditions = [ state.allowed?(:bar) ]
            raise Taipo::SyntaxError, msg unless conditions.all?
            state.prohibit_all except: [ :lpr, :hsh, :cln, :spc_bar, :nme ]
          when '<' # lab
          Severity: Minor
          Found in lib/taipo/parser/validater.rb and 1 other location - About 15 mins to fix
          lib/taipo/parser/validater.rb on lines 299..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status