Sign upLogin

q9f/eth.rb

View on GitHub
Star
lib/eth/tx.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method new has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def new(params, chain_id = Chain::ETHEREUM)

      # if we deal with max gas fee parameter, attempt EIP-1559
      unless params[:max_gas_fee].nil?
        params[:chain_id] = chain_id if params[:chain_id].nil?
Severity: Minor
Found in lib/eth/tx.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_params has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_params(fields)
      if fields[:nonce].nil? or fields[:nonce] < 0
        raise ParameterError, "Invalid signer nonce #{fields[:nonce]}!"
      end
      if fields[:gas_limit].nil? or
Severity: Minor
Found in lib/eth/tx.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method estimate_intrinsic_gas has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def estimate_intrinsic_gas(data = "", list = [])
      gas = DEFAULT_GAS_LIMIT
      unless data.nil? or data.empty?
        data = Util.hex_to_bin data if Util.hex? data
Severity: Minor
Found in lib/eth/tx.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status