Sign upLogin

q9f/ruby-eth

View on GitHub
Star

Showing 6 of 6 total issues

Class Tx has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Tx

    include RLP::Sedes::Serializable
    extend Sedes
Severity: Minor
Found in lib/eth/tx.rb - About 3 hrs to fix

    Method recover_public_key_from_signature has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def recover_public_key_from_signature(message_hash, signature, rec_id, is_compressed)
        return nil if rec_id < 0 or signature.bytesize != 65
        init_ffi_ssl

        signature = FFI::MemoryPointer.from_string(signature)
    Severity: Minor
    Found in lib/eth/open_ssl.rb - About 1 hr to fix

      Method sign_compact has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def sign_compact(hash, private_key, public_key_hex)
        private_key = [private_key].pack("H*") if private_key.bytesize >= 64
        pubkey_compressed = false

        init_ffi_ssl
      Severity: Minor
      Found in lib/eth/open_ssl.rb - About 1 hr to fix

        Method sign_compact has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def sign_compact(hash, private_key, public_key_hex)
        private_key = [private_key].pack("H*") if private_key.bytesize >= 64
        pubkey_compressed = false

        init_ffi_ssl
        Severity: Minor
        Found in lib/eth/open_ssl.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method ecdsa_signature has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def ecdsa_signature
      return @ecdsa_signature if @ecdsa_signature

      if [v, r, s].all? && (v > 0)
        s_v = (self.chain_id) ? (v - (self.chain_id * 2) - 8) : v
        Severity: Minor
        Found in lib/eth/tx.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method normalize_address has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def normalize_address(address)
      if address.nil? || address == ''
        ''
      elsif address.size == 40
        hex_to_bin address
        Severity: Minor
        Found in lib/eth/utils.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language