qcminecraft/Carbon-Forum-F

View on GitHub

Showing 851 of 851 total issues

Avoid too many return statements within this method.
Open

            return;
Severity: Major
Found in library/Uploader.class.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return;
    Severity: Major
    Found in library/Uploader.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return;
      Severity: Major
      Found in library/Uploader.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in library/Uploader.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return false;
          Severity: Major
          Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return false;
            Severity: Major
            Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->sendCommand('Username', base64_encode($response), 235);
                Severity: Major
                Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true;
                  Severity: Major
                  Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                uploader.on('error', function (code, file) {
                                    if (code == 'Q_TYPE_DENIED' || code == 'F_EXCEED_SIZE') {
                                        addFile(file);
                                    }
                                });
                    Severity: Minor
                    Found in static/editor/dialogs/video/video.js and 2 other locations - About 30 mins to fix
                    static/editor/dialogs/attachment/attachment.js on lines 518..522
                    static/editor/dialogs/image/image.js on lines 733..737

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                uploader.on('error', function (code, file) {
                                    if (code == 'Q_TYPE_DENIED' || code == 'F_EXCEED_SIZE') {
                                        addFile(file);
                                    }
                                });
                    Severity: Minor
                    Found in static/editor/dialogs/image/image.js and 2 other locations - About 30 mins to fix
                    static/editor/dialogs/attachment/attachment.js on lines 518..522
                    static/editor/dialogs/video/video.js on lines 748..752

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (this.getParam('light') == true)
                                    this.params.toolbar = this.params.gutter = false;
                    Severity: Minor
                    Found in static/editor/third-party/SyntaxHighlighter/shCore.js and 1 other location - About 30 mins to fix
                    static/editor/third-party/SyntaxHighlighter/shCore.js on lines 2336..2337

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                uploader.on('error', function (code, file) {
                                    if (code == 'Q_TYPE_DENIED' || code == 'F_EXCEED_SIZE') {
                                        addFile(file);
                                    }
                                });
                    Severity: Minor
                    Found in static/editor/dialogs/attachment/attachment.js and 2 other locations - About 30 mins to fix
                    static/editor/dialogs/image/image.js on lines 733..737
                    static/editor/dialogs/video/video.js on lines 748..752

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ( id != tabSrc ) {
                                body.style.zIndex = 1;
                            } else {
                                body.style.zIndex = 200;
                            }
                    Severity: Minor
                    Found in static/editor/dialogs/searchreplace/searchreplace.js and 1 other location - About 30 mins to fix
                    static/editor/dialogs/help/help.js on lines 28..32

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ( id != tabSrc ) {
                                body.style.zIndex = 1;
                            } else {
                                body.style.zIndex = 200;
                            }
                    Severity: Minor
                    Found in static/editor/dialogs/help/help.js and 1 other location - About 30 mins to fix
                    static/editor/dialogs/searchreplace/searchreplace.js on lines 30..34

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (this.getParam('light') == true)
                                    this.params.toolbar = this.params.gutter = false;
                    Severity: Minor
                    Found in static/editor/third-party/SyntaxHighlighter/shCore.js and 1 other location - About 30 mins to fix
                    static/editor/third-party/SyntaxHighlighter/shCore.js on lines 2216..2217

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function trim3 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function trim3(str) {
                        if(str){
                            str = str.replace(/^(\s|\u00A0)+/, '');
                            for (var i = str.length - 1; i >= 0; i--) {
                                if (/\S/.test(str.charAt(i))) {
                    Severity: Minor
                    Found in static/js/mobile/global.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function CheckUserNameExist has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function CheckUserNameExist() {
                        if ($("#UserName").val()) {
                            $.ajax({
                                url: WebsitePath + '/json/user_exist',
                                data: {
                    Severity: Minor
                    Found in static/js/default/global.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function trim3 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function trim3(str) {
                        if (str) {
                            str = str.replace(/^(\s|\u00A0)+/, '');
                            for (var i = str.length - 1; i >= 0; i--) {
                                if (/\S/.test(str.charAt(i))) {
                    Severity: Minor
                    Found in static/js/default/topic.function.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function RecoverTopicContents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function RecoverTopicContents() {
                        var DraftTitle = localStorage.getItem(Prefix + "TopicTitle");
                        var DraftContent = localStorage.getItem(Prefix + "TopicContent");
                        var DraftTagsList = JSON.parse(localStorage.getItem(Prefix + "TopicTagsList"));
                        if (DraftTitle) {
                    Severity: Minor
                    Found in static/js/default/new.function.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language