qcminecraft/Carbon-Forum-F

View on GitHub
library/Geetestlib.class.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method post_request has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function post_request($url, $postdata = '') {
        if (!$postdata) {
            return false;
        }

Severity: Minor
Found in library/Geetestlib.class.php - About 1 hr to fix

    Method send_request has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function send_request($url) {
    
            if (function_exists('curl_exec')) {
                $ch = curl_init();
                curl_setopt($ch, CURLOPT_URL, $url);
    Severity: Minor
    Found in library/Geetestlib.class.php - About 1 hr to fix

      Function post_request has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function post_request($url, $postdata = '') {
              if (!$postdata) {
                  return false;
              }
      
      
      Severity: Minor
      Found in library/Geetestlib.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function send_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function send_request($url) {
      
              if (function_exists('curl_exec')) {
                  $ch = curl_init();
                  curl_setopt($ch, CURLOPT_URL, $url);
      Severity: Minor
      Found in library/Geetestlib.class.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method success_validate has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function success_validate($challenge, $validate, $seccode,$param, $json_format=1) {
      Severity: Minor
      Found in library/Geetestlib.class.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status