Sign upLogin

qcminecraft/Carbon-Forum-F

View on GitHub
Star
library/PHPMailer.smtp.class.php

Summary

Maintainability
F
6 days
Test Coverage

File PHPMailer.smtp.class.php has 614 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * PHPMailer RFC821 SMTP email transport class.
 * PHP Version 5
 * @package PHPMailer
Severity: Major
Found in library/PHPMailer.smtp.class.php - About 1 day to fix

    Function authenticate has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        public function authenticate(
        $username,
        $password,
        $authtype = null,
        $realm = '',
    Severity: Minor
    Found in library/PHPMailer.smtp.class.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method authenticate has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function authenticate(
        $username,
        $password,
        $authtype = null,
        $realm = '',
    Severity: Major
    Found in library/PHPMailer.smtp.class.php - About 4 hrs to fix

      SMTP has 35 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class SMTP
{
    /**
     * The PHPMailer SMTP version number.
     * @var string
      Severity: Minor
      Found in library/PHPMailer.smtp.class.php - About 4 hrs to fix

        Function data has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function data($msg_data)
    {
        //This will use the standard timelimit
        if (!$this->sendCommand('DATA', 'DATA', 354)) {
            return false;
        Severity: Minor
        Found in library/PHPMailer.smtp.class.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method connect has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function connect($host, $port = null, $timeout = 30, $options = array())
    {
        static $streamok;
        //This is enabled by default since 5.0.0 but some providers disable it
        //Check this once and cache the result
        Severity: Major
        Found in library/PHPMailer.smtp.class.php - About 2 hrs to fix

          Function parseHelloFields has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseHelloFields($type)
    {
        $this->server_caps = array();
        $lines = explode("\n", $this->helo_rply);
          Severity: Minor
          Found in library/PHPMailer.smtp.class.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method data has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function data($msg_data)
    {
        //This will use the standard timelimit
        if (!$this->sendCommand('DATA', 'DATA', 354)) {
            return false;
          Severity: Minor
          Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

            Method sendCommand has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function sendCommand($command, $commandstring, $expect)
    {
        if (!$this->connected()) {
            $this->setError("Called $command without being connected");
            return false;
            Severity: Minor
            Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

              Function get_lines has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function get_lines()
    {
        // If the connection is bad, give up straight away
        if (!is_resource($this->smtp_conn)) {
            return '';
              Severity: Minor
              Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_lines has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function get_lines()
    {
        // If the connection is bad, give up straight away
        if (!is_resource($this->smtp_conn)) {
            return '';
              Severity: Minor
              Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

                Method parseHelloFields has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function parseHelloFields($type)
    {
        $this->server_caps = array();
        $lines = explode("\n", $this->helo_rply);
                Severity: Minor
                Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

                  Method edebug has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function edebug($str, $level = 0)
    {
        if ($level > $this->do_debug) {
            return;
        }
                  Severity: Minor
                  Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

                    Function connect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function connect($host, $port = null, $timeout = 30, $options = array())
    {
        static $streamok;
        //This is enabled by default since 5.0.0 but some providers disable it
        //Check this once and cache the result
                    Severity: Minor
                    Found in library/PHPMailer.smtp.class.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method authenticate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            $username,
        $password,
        $authtype = null,
        $realm = '',
        $workstation = '',
                    Severity: Minor
                    Found in library/PHPMailer.smtp.class.php - About 45 mins to fix

                      Function getServerExt has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getServerExt($name)
    {
        if (!$this->server_caps) {
            $this->setError('No HELO/EHLO was sent');
            return null;
                      Severity: Minor
                      Found in library/PHPMailer.smtp.class.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                              return true;
                      Severity: Major
                      Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return false;
                        Severity: Major
                        Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return $this->sendCommand('Username', base64_encode($msg3), 235);
                          Severity: Major
                          Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return $this->sendCommand('Username', base64_encode($response), 235);
                            Severity: Major
                            Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return false;
                              Severity: Major
                              Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                    return false;
                                Severity: Major
                                Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                      return false;
                                  Severity: Major
                                  Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                        return false;
                                    Severity: Major
                                    Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                          return false;
                                      Severity: Major
                                      Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                            return false;
                                        Severity: Major
                                        Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                              return false;
                                          Severity: Major
                                          Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                                return false;
                                            Severity: Major
                                            Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                              return false;
                                              Severity: Major
                                              Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                        return $this->server_caps[$name];
                                                Severity: Major
                                                Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                      return false;
                                                  Severity: Major
                                                  Found in library/PHPMailer.smtp.class.php - About 30 mins to fix

                                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                            switch ($this->Debugoutput) {
            case 'error_log':
                //Don't output, just log
                error_log($str);
                break;
                                                    Severity: Major
                                                    Found in library/PHPMailer.smtp.class.php and 1 other location - About 2 hrs to fix
                                                    library/PHPMailer.class.php on lines 711..734

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 130.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    There are no issues that match your filters.

                                                    Category
                                                    Status