qcubed/framework

Method Form_Create has 48 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        protected function Form_Create() {
            // Define the Simple Message Dialog Box
            $this->dlgSimpleMessage = new QDialog($this);
            $this->dlgSimpleMessage->Title = "Hello World!";
            $this->dlgSimpleMessage->Text = '<p><em>Hello, world!</em></p><p>This is a standard, no-frills dialog box.</p><p>Notice how the contents of the dialog '.

Missing class import via use statement (line '55', column '27').

Open

            $this->pnlAnswer = new QPanel($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '88', column '68').

Open

            $this->dlgValidation->AddAction (new QDialog_ButtonEvent(), new QAjaxAction('dlgValidate_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '99', column '40').

Open

            $this->btnValidation->AddAction(new QClickEvent(), new QShowDialog($this->dlgValidation));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '76', column '40').

Open

            $this->btnCalculator->AddAction(new QClickEvent(), new QAjaxAction('btnCalculator_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '76', column '59').

Open

            $this->btnCalculator->AddAction(new QClickEvent(), new QAjaxAction('btnCalculator_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '58', column '33').

Open

            $this->btnDisplayYesNo = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '65', column '37').

Open

            $this->dlgCalculatorWidget = new CalculatorWidget('btnCalculator_Close', $this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '53', column '75').

Open

            $this->btnDisplaySimpleMessageJsOnly->AddAction(new QClickEvent(), new QShowDialog($this->dlgSimpleMessage));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '97', column '31').

Open

            $this->btnValidation = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '109', column '41').

Open

            $this->btnInfoMessage->AddAction(new QClickEvent(), new QAjaxAction('btnGetInfo_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '192', column '20').

Open

            $dlgYesNo = new QDialog();    // Note here there is no "$this" as the first parameter. By leaving this off, you

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '51', column '47').

Open

            $this->btnDisplaySimpleMessageJsOnly = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '88', column '41').

Open

            $this->dlgValidation->AddAction (new QDialog_ButtonEvent(), new QAjaxAction('dlgValidate_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '45', column '41').

Open

            $this->btnDisplaySimpleMessage = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '107', column '32').

Open

            $this->btnInfoMessage = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '53', column '56').

Open

            $this->btnDisplaySimpleMessageJsOnly->AddAction(new QClickEvent(), new QShowDialog($this->dlgSimpleMessage));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '197', column '30').

Open

            $dlgYesNo->AddAction (new QDialog_ButtonEvent(), new QAjaxAction ('dlgYesNo_Button'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '47', column '69').

Open

            $this->btnDisplaySimpleMessage->AddAction(new QClickEvent(), new QAjaxAction('btnDisplaySimpleMessage_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '174', column '24').

Open

            $dlg->AddAction(new QDialog_ButtonEvent(), new QAjaxAction('infoClick')); // Add the action to detect a button click.

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '74', column '31').

Open

            $this->btnCalculator = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '79', column '31').

Open

            $this->dlgValidation = new QDialog($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '103', column '33').

Open

            $this->btnErrorMessage = new QButton($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '60', column '61').

Open

            $this->btnDisplayYesNo->AddAction(new QClickEvent(), new QAjaxAction('showYesNoClick'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '93', column '26').

Open

            $this->txtFloat = new QFloatTextBox($this->dlgValidation);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '105', column '61').

Open

            $this->btnErrorMessage->AddAction(new QClickEvent(), new QAjaxAction('btnErrorMessage_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '109', column '60').

Open

            $this->btnInfoMessage->AddAction(new QClickEvent(), new QAjaxAction('btnGetInfo_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '174', column '51').

Open

            $dlg->AddAction(new QDialog_ButtonEvent(), new QAjaxAction('infoClick')); // Add the action to detect a button click.

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '32', column '34').

Open

            $this->dlgSimpleMessage = new QDialog($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '60', column '42').

Open

            $this->btnDisplayYesNo->AddAction(new QClickEvent(), new QAjaxAction('showYesNoClick'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '99', column '59').

Open

            $this->btnValidation->AddAction(new QClickEvent(), new QShowDialog($this->dlgValidation));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '197', column '57').

Open

            $dlgYesNo->AddAction (new QDialog_ButtonEvent(), new QAjaxAction ('dlgYesNo_Button'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '72', column '26').

Open

            $this->txtValue = new QTextBox($this);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '47', column '50').

Open

            $this->btnDisplaySimpleMessage->AddAction(new QClickEvent(), new QAjaxAction('btnDisplaySimpleMessage_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '105', column '42').

Open

            $this->btnErrorMessage->AddAction(new QClickEvent(), new QAjaxAction('btnErrorMessage_Click'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'QApplication' in method 'Form_Create'.

Open

            $this->btnDisplaySimpleMessage->Text = QApplication::Translate('Display Simple Message QDialog');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QDialog' in method 'btnGetInfo_Click'.

Open

            $dlg = QDialog::Alert("Which do you want?", ['This', 'That']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QApplication' in method 'Form_Create'.

Open

            $this->btnDisplayYesNo->Text = QApplication::Translate('Do you love me?');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QApplication' in method 'showYesNoClick'.

Open

            $dlgYesNo->Text = QApplication::Translate("Do you like QCubed?");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QDialog' in method 'btnErrorMessage_Click'.

Open

            $dlg = QDialog::Alert("Don't do that!");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QApplication' in method 'dlgYesNo_Button'.

Open

                $this->pnlAnswer->Text = QApplication::Translate('They love me not');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'QDialog' in method 'infoClick'.

Open

            QDialog::Alert($strParameter . ' was clicked.', ['OK']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method dlgYesNo_Button uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->pnlAnswer->Text = QApplication::Translate('They love me not');
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'QApplication' in method 'dlgYesNo_Button'.

Open

                $this->pnlAnswer->Text = QApplication::Translate('They love me');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid unused parameters such as '$strParameter'.

Open

        protected function btnCalculator_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function btnDisplaySimpleMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function btnCalculator_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strControlId'.

Open

        public function dlgValidate_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strControlId'.

Open

        protected function btnCalculator_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        public function dlgValidate_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function btnErrorMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strControlId'.

Open

        protected function btnErrorMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function dlgYesNo_Button($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strParameter'.

Open

        protected function btnErrorMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function btnGetInfo_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strControlId'.

Open

        protected function btnDisplaySimpleMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strControlId'.

Open

        protected function btnGetInfo_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strParameter'.

Open

        protected function btnGetInfo_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strParameter'.

Open

        protected function btnDisplaySimpleMessage_Click($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$strFormId'.

Open

        protected function infoClick($strFormId, $strControlId, $strParameter) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid excessively long variable names like $btnDisplaySimpleMessage. Keep variable name length under 20.

Open

        protected $btnDisplaySimpleMessage;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $btnDisplaySimpleMessageJsOnly. Keep variable name length under 20.

Open

        protected $btnDisplaySimpleMessageJsOnly;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The method btnCalculator_Close is not named in camelCase.

Open

        public function btnCalculator_Close() {
            $this->txtValue->Text = $this->dlgCalculatorWidget->Value;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method Form_Create is not named in camelCase.

Open

        protected function Form_Create() {
            // Define the Simple Message Dialog Box
            $this->dlgSimpleMessage = new QDialog($this);
            $this->dlgSimpleMessage->Title = "Hello World!";
            $this->dlgSimpleMessage->Text = '<p><em>Hello, world!</em></p><p>This is a standard, no-frills dialog box.</p><p>Notice how the contents of the dialog '.

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method btnErrorMessage_Click is not named in camelCase.

Open

        protected function btnErrorMessage_Click($strFormId, $strControlId, $strParameter) {

            /**
             * Bring up the dialog. Here we specify a simple dialog with no buttons.
             * With no buttons, a close box will be displayed so the user can close the dialog.

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method dlgValidate_Click is not named in camelCase.

Open

        public function dlgValidate_Click($strFormId, $strControlId, $strParameter) {
            if ($strParameter == 'cancel') {
                $this->txtFloat->Text = '';
            }
            $this->dlgValidation->Close();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method btnDisplaySimpleMessage_Click is not named in camelCase.

Open

        protected function btnDisplaySimpleMessage_Click($strFormId, $strControlId, $strParameter) {
            // "Show" the Dialog Box using the Open() method
            $this->dlgSimpleMessage->Open();
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method btnCalculator_Click is not named in camelCase.

Open

        protected function btnCalculator_Click($strFormId, $strControlId, $strParameter) {
            // Setup the Calculator Widget's Value
            $this->dlgCalculatorWidget->Value = trim($this->txtValue->Text);

            // And Show it

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method dlgYesNo_Button is not named in camelCase.

Open

        protected function dlgYesNo_Button($strFormId, $strControlId, $strParameter) {
            $dlg = $this->GetControl($strControlId);    // get the dialog object from the form.
            if ($strParameter == 'Yes') {
                $this->pnlAnswer->Text = QApplication::Translate('They love me');
            } else {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method btnGetInfo_Click is not named in camelCase.

Open

        protected function btnGetInfo_Click($strFormId, $strControlId, $strParameter) {
            /**
             * Bring up the dialog. Here we specify two buttons.
             * With two or more buttons, we must detect a button click and close the dialog if a button is clicked.
             */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}