Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/advanced_ajax/renamer_2.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '37', column '46').
Open

            $this->txtArray[$intIndex]->AddAction(new QEnterKeyEvent(), new QTerminateAction());
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '36', column '68').
Open

            $this->txtArray[$intIndex]->AddAction(new QEnterKeyEvent(), new QAjaxAction('TextItem_Save'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '37', column '68').
Open

            $this->txtArray[$intIndex]->AddAction(new QEnterKeyEvent(), new QTerminateAction());
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '40', column '46').
Open

            $this->txtArray[$intIndex]->AddAction(new QEscapeKeyEvent(), new QAjaxAction('TextItem_Cancel'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '69').
Open

            $this->txtArray[$intIndex]->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '35', column '46').
Open

            $this->txtArray[$intIndex]->AddAction(new QBlurEvent(), new QAjaxAction('TextItem_Save'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '23', column '65').
Open

            $this->lblArray[$intIndex]->AddAction(new QClickEvent(), new QJavaScriptAction('lblArray_Click(this)'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '35', column '64').
Open

            $this->txtArray[$intIndex]->AddAction(new QBlurEvent(), new QAjaxAction('TextItem_Save'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '40', column '69').
Open

            $this->txtArray[$intIndex]->AddAction(new QEscapeKeyEvent(), new QAjaxAction('TextItem_Cancel'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '30', column '37').
Open

            $this->txtArray[$intIndex] = new QTextBox($this, 'textbox' . $intIndex);
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '46').
Open

            $this->txtArray[$intIndex]->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '16', column '37').
Open

            $this->lblArray[$intIndex] = new QLabel($this, 'label' . $intIndex);
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '23', column '46').
Open

            $this->lblArray[$intIndex]->AddAction(new QClickEvent(), new QJavaScriptAction('lblArray_Click(this)'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '36', column '46').
Open

            $this->txtArray[$intIndex]->AddAction(new QEnterKeyEvent(), new QAjaxAction('TextItem_Save'));
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'QApplication' in method 'TextItem_Cancel'.
Open

        QApplication::ExecuteJavaScript('intSelectedIndex = -1;');
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'TextItem_Save'.
Open

        QApplication::ExecuteJavaScript('intSelectedIndex = -1;');
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$strFormId'.
Open

    protected function TextItem_Save($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strControlId'.
Open

    protected function TextItem_Save($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

    protected function TextItem_Cancel($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strControlId'.
Open

    protected function TextItem_Cancel($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method Form_Create is not named in camelCase.
Open

    protected function Form_Create() {
        for ($intIndex = 0; $intIndex < 10; $intIndex++) {
            // Create the Label -- we must remember to explicitly specify the
            // Control ID so that we can code javascript against it
            // Note, we are using the regular QLabel and not our custom SelectableLabel
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method TextItem_Save is not named in camelCase.
Open

    protected function TextItem_Save($strFormId, $strControlId, $strParameter) {
        $strValue = trim($this->txtArray[$strParameter]->Text);

        if (strlen($strValue)) {
            // Copy the Textbox value back to the Label
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method TextItem_Cancel is not named in camelCase.
Open

    protected function TextItem_Cancel($strFormId, $strControlId, $strParameter) {
        // Hide the Textbox, get the label cleaned up and ready to go
        $this->lblArray[$strParameter]->Display = true;
        $this->txtArray[$strParameter]->Display = false;
        $this->lblArray[$strParameter]->CssClass = 'renamer_item';
Severity: Minor
Found in assets/php/examples/advanced_ajax/renamer_2.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status