Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/basic_qform/calculator.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '30', column '38').
Open

        $this->btnCalculate->AddAction(new QClickEvent(), new QServerAction('btnCalculate_Click'));
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '28', column '29').
Open

        $this->btnCalculate = new QButton($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '18', column '26').
Open

        $this->txtValue1 = new QTextBox($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '52', column '15').
Open

                throw new Exception('Invalid Action');
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '22', column '29').
Open

        $this->lstOperation = new QListBox($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '20', column '26').
Open

        $this->txtValue2 = new QTextBox($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '30', column '57').
Open

        $this->btnCalculate->AddAction(new QClickEvent(), new QServerAction('btnCalculate_Click'));
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '32', column '26').
Open

        $this->lblResult = new QLabel($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$strControlId'.
Open

    protected function btnCalculate_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

    protected function btnCalculate_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

    protected function btnCalculate_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method Form_Create is not named in camelCase.
Open

    protected function Form_Create() {
        $this->txtValue1 = new QTextBox($this);

        $this->txtValue2 = new QTextBox($this);
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method btnCalculate_Click is not named in camelCase.
Open

    protected function btnCalculate_Click($strFormId, $strControlId, $strParameter) {
        switch ($this->lstOperation->SelectedValue) {
            case 'add':
                $mixResult = $this->txtValue1->Text + $this->txtValue2->Text;
                break;
Severity: Minor
Found in assets/php/examples/basic_qform/calculator.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status