Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/basic_qform/process_flow.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '34', column '35').
Open

        $this->btnButton->AddAction(new QClickEvent(), new QServerAction('btnButton_Click'));
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '21', column '27').
Open

        $this->lblMessage = new QLabel($this);
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '26', column '26').
Open

        $this->btnButton = new QButton($this);
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '34', column '54').
Open

        $this->btnButton->AddAction(new QClickEvent(), new QServerAction('btnButton_Click'));
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$strControlId'.
Open

    protected function btnButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

    protected function btnButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

    protected function btnButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method Form_Create is not named in camelCase.
Open

    protected function Form_Create() {
        _p('<b>Form_Create</b> called<br/>', false);
        // Define the Label -- Set HtmlEntities to false because we intend on hard coding HTML into the Control
        $this->lblMessage = new QLabel($this);
        $this->lblMessage->HtmlEntities = false;
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Form_Validate is not named in camelCase.
Open

    protected function Form_Validate() {
        _p('<b>Form_Validate</b> called<br/>', false);

        // Form_Validate needs to return true or false
        return true;
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method btnButton_Click is not named in camelCase.
Open

    protected function btnButton_Click($strFormId, $strControlId, $strParameter) {
        _p('<b>btnButton_Click</b> called<br/>', false);
        $this->lblMessage->Text = 'Hello, world!<br/>';
        $this->lblMessage->Text .= 'Note that instead of <b>Form_Create</b> being called, we are now calling <b>Form_Load</b> and <b>btnButton_Click</b>';
    }
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Form_Run is not named in camelCase.
Open

    protected function Form_Run() {
        _p('<br><br><br><br><br>', false); // Compensating for the examples header

        _p('<b>Form_Run</b> called<br/>', false);
    }
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Form_Load is not named in camelCase.
Open

    protected function Form_Load() {
        _p('<b>Form_Load</b> called<br/>', false);
    }
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Form_PreRender is not named in camelCase.
Open

    protected function Form_PreRender() {
        _p('<b>Form_PreRender</b> called<br/>', false);
    }
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Form_Exit is not named in camelCase.
Open

    protected function Form_Exit() {
        _p('<b>Form_Exit</b> called<br/>', false);
    }
Severity: Minor
Found in assets/php/examples/basic_qform/process_flow.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status