qcubed/framework

View on GitHub
assets/php/examples/communication/example_service.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '29', column '28').
Open

        $dttToReturn = new QDateTime($intYear . '-' . $intMonth . '-' . $intDay);

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'QQ' in method 'GetPeople'.
Open

                        QQ::Equal(QQN::Person()->LastName, $strLastName)

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Person' in method 'GetPeople'.
Open

        return Person::QueryArray(
                        QQ::Equal(QQN::Person()->LastName, $strLastName)
        );

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method AddNumbers is not named in camelCase.
Open

    public function AddNumbers($intNumber1, $intNumber2) {
        return $intNumber1 + $intNumber2;
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method GetPeople is not named in camelCase.
Open

    public function GetPeople($strLastName) {
        return Person::QueryArray(
                        QQ::Equal(QQN::Person()->LastName, $strLastName)
        );
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method GetDate is not named in camelCase.
Open

    public function GetDate($intMonth, $intDay, $intYear) {
        $dttToReturn = new QDateTime($intYear . '-' . $intMonth . '-' . $intDay);
        return $dttToReturn;
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status