Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/datagrid/intro.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '11', column '27').
Open

        $this->dtgPersons = new QHtmlTable($this);
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Person' in method 'dtgPersons_Bind'.
Open

        $this->dtgPersons->DataSource = Person::LoadAll();
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method Form_Create is not named in camelCase.
Open

    protected function Form_Create() {
        // Define the DataGrid
        $this->dtgPersons = new QHtmlTable($this);

        // Define Columns
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method dtgPerson_FirstName_Render is not named in camelCase.
Open

    public function dtgPerson_FirstName_Render(Person $objPerson) {
        return "First Name is {$objPerson->FirstName}";
    }
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method dtgPersons_Bind is not named in camelCase.
Open

    protected function dtgPersons_Bind() {
        // We load the data source, and set it to the datagrid's DataSource parameter
        $this->dtgPersons->DataSource = Person::LoadAll();
    }
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method dtgPerson_LastName_Render is not named in camelCase.
Open

    public function dtgPerson_LastName_Render(Person $objPerson) {
        return "Last Name {$objPerson->LastName}";
    }
Severity: Minor
Found in assets/php/examples/datagrid/intro.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status