Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/dynamic/inline_editing.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method Form_Create has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected function Form_Create() {
            // Define the DataGrid
            $this->dtgPersons = new QDataGrid($this);

            // Define Columns -- we will define render helper methods to help with the rendering
Severity: Minor
Found in assets/php/examples/dynamic/inline_editing.php - About 1 hr to fix

    Function EditColumn_Render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            public function EditColumn_Render(Person $objPerson) {
            if (($objPerson->Id == $this->intEditPersonId) ||
                (($this->intEditPersonId == -1) && (!$objPerson->Id)))
                // We are rendering the row of the person we are editing OR we are rending the row
                // of the NEW (blank) person.  Go ahead and render the Save and Cancel buttons.
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '70', column '36').
    Open

                $this->btnCancel->AddAction(new QClickEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '18', column '28').
    Open

                $this->dtgPersons = new QDataGrid($this);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '45', column '30').
    Open

                $this->txtFirstName = new QTextBox($this->dtgPersons);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '50', column '39').
    Open

                $this->txtFirstName->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '38').
    Open

                $this->txtLastName->AddAction(new QEscapeKeyEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '57', column '38').
    Open

                $this->txtLastName->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '61', column '25').
    Open

                $this->btnSave = new QButton($this->dtgPersons);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '185', column '22').
    Open

                    $objPerson = new Person();
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '76', column '33').
    Open

                $this->btnNew->AddAction(new QClickEvent(), new QAjaxAction('btnNew_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '68', column '27').
    Open

                $this->btnCancel = new QButton($this->dtgPersons);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '62').
    Open

                $this->txtFirstName->AddAction(new QEscapeKeyEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '52', column '29').
    Open

                $this->txtLastName = new QTextBox($this->dtgPersons);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '61').
    Open

                $this->txtLastName->AddAction(new QEscapeKeyEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '57', column '61').
    Open

                $this->txtLastName->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '88', column '37').
    Open

                    array_push($objPersonArray, new Person());
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '39').
    Open

                $this->txtFirstName->AddAction(new QEscapeKeyEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '63', column '53').
    Open

                $this->btnSave->AddAction(new QClickEvent(), new QAjaxAction('btnSave_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '154', column '30').
    Open

                        $btnEdit->AddAction(new QClickEvent(), new QAjaxAction('btnEdit_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '76', column '52').
    Open

                $this->btnNew->AddAction(new QClickEvent(), new QAjaxAction('btnNew_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '154', column '49').
    Open

                        $btnEdit->AddAction(new QClickEvent(), new QAjaxAction('btnEdit_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '63', column '34').
    Open

                $this->btnSave->AddAction(new QClickEvent(), new QAjaxAction('btnSave_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '70', column '55').
    Open

                $this->btnCancel->AddAction(new QClickEvent(), new QAjaxAction('btnCancel_Click'));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '74', column '24').
    Open

                $this->btnNew = new QButton($this);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '50', column '62').
    Open

                $this->txtFirstName->AddAction(new QEscapeKeyEvent(), new QTerminateAction());
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '151', column '21').
    Open

                        $btnEdit = new QButton($this->dtgPersons, $strControlId);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'QApplication' in method 'btnEdit_Click'.
    Open

                QApplication::ExecuteControlCommand($this->txtFirstName->ControlId, 'focus');
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Person' in method 'btnEdit_Click'.
    Open

                $objPerson = Person::Load($strParameter);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QApplication' in method 'LastNameColumn_Render'.
    Open

                    return QApplication::HtmlEntities($objPerson->LastName);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Person' in method 'dtgPersons_Bind'.
    Open

                $objPersonArray = $this->dtgPersons->DataSource = Person::LoadAll(QQ::Clause(
                $this->dtgPersons->OrderByClause,
                $this->dtgPersons->LimitClause
            ));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method EditColumn_Render uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                else {
                // Get the Edit button for this row (we will create it if it doesn't yet exist)
                $strControlId = 'btnEdit' . $objPerson->Id;
                $btnEdit = $this->GetControl($strControlId);
                if (!$btnEdit) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'QApplication' in method 'FirstNameColumn_Render'.
    Open

                    return QApplication::HtmlEntities($objPerson->FirstName);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Person' in method 'btnSave_Click'.
    Open

                    $objPerson = Person::Load($this->intEditPersonId);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QQ' in method 'dtgPersons_Bind'.
    Open

                $objPersonArray = $this->dtgPersons->DataSource = Person::LoadAll(QQ::Clause(
                $this->dtgPersons->OrderByClause,
                $this->dtgPersons->LimitClause
            ));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$strFormId'.
    Open

            protected function btnCancel_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strControlId'.
    Open

            protected function btnCancel_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strFormId'.
    Open

            protected function btnEdit_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strFormId'.
    Open

            protected function btnSave_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strParameter'.
    Open

            protected function btnCancel_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strFormId'.
    Open

            protected function btnNew_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strParameter'.
    Open

            protected function btnNew_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strControlId'.
    Open

            protected function btnEdit_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strControlId'.
    Open

            protected function btnSave_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strParameter'.
    Open

            protected function btnSave_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$strControlId'.
    Open

            protected function btnNew_Click($strFormId, $strControlId, $strParameter) {
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    The method LastNameColumn_Render is not named in camelCase.
    Open

            public function LastNameColumn_Render(Person $objPerson) {
            if (($objPerson->Id == $this->intEditPersonId) ||
                (($this->intEditPersonId == -1) && (!$objPerson->Id)))
                return $this->txtLastName->RenderWithError(false);
            else
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method Form_Create is not named in camelCase.
    Open

            protected function Form_Create() {
            // Define the DataGrid
            $this->dtgPersons = new QDataGrid($this);

            // Define Columns -- we will define render helper methods to help with the rendering
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method btnEdit_Click is not named in camelCase.
    Open

            protected function btnEdit_Click($strFormId, $strControlId, $strParameter) {
            $this->intEditPersonId = $strParameter;
            $objPerson = Person::Load($strParameter);
            $this->txtFirstName->Text = $objPerson->FirstName;
            $this->txtLastName->Text = $objPerson->LastName;
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method Form_PreRender is not named in camelCase.
    Open

            protected function Form_PreRender() {
            // We want to force the datagrid to refresh on EVERY button click
            // Normally, the datagrid won't re-render on the ajaxactions because nothing
            // in the datagrid, itself, is being modified.  But considering that every ajax action
            // on the page (e.g. every button click) makes changes to things that AFFECT the datagrid,
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method btnCancel_Click is not named in camelCase.
    Open

            protected function btnCancel_Click($strFormId, $strControlId, $strParameter) {
            $this->intEditPersonId = null;
        }
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method FirstNameColumn_Render is not named in camelCase.
    Open

            public function FirstNameColumn_Render(Person $objPerson) {
            if (($objPerson->Id == $this->intEditPersonId) ||
                (($this->intEditPersonId == -1) && (!$objPerson->Id)))
                return $this->txtFirstName->RenderWithError(false);
            else
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method dtgPersons_Bind is not named in camelCase.
    Open

            protected function dtgPersons_Bind() {
            $objPersonArray = $this->dtgPersons->DataSource = Person::LoadAll(QQ::Clause(
                $this->dtgPersons->OrderByClause,
                $this->dtgPersons->LimitClause
            ));
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method EditColumn_Render is not named in camelCase.
    Open

            public function EditColumn_Render(Person $objPerson) {
            if (($objPerson->Id == $this->intEditPersonId) ||
                (($this->intEditPersonId == -1) && (!$objPerson->Id)))
                // We are rendering the row of the person we are editing OR we are rending the row
                // of the NEW (blank) person.  Go ahead and render the Save and Cancel buttons.
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method btnSave_Click is not named in camelCase.
    Open

            protected function btnSave_Click($strFormId, $strControlId, $strParameter) {
            if ($this->intEditPersonId == -1)
                $objPerson = new Person();
            else
                $objPerson = Person::Load($this->intEditPersonId);
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method btnNew_Click is not named in camelCase.
    Open

            protected function btnNew_Click($strFormId, $strControlId, $strParameter) {
            $this->intEditPersonId = -1;
            $this->txtFirstName->Text = '';
            $this->txtLastName->Text = '';
    Severity: Minor
    Found in assets/php/examples/dynamic/inline_editing.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status